Skip to content

Conversation

ilan-gold
Copy link
Contributor

@ilan-gold ilan-gold commented Aug 29, 2025

@ilan-gold ilan-gold added this to the 0.12.2 milestone Aug 29, 2025
Copy link

codecov bot commented Aug 29, 2025

Codecov Report

❌ Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.56%. Comparing base (e2d7503) to head (fda5ad7).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/anndata/_io/zarr.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2097      +/-   ##
==========================================
- Coverage   85.57%   85.56%   -0.01%     
==========================================
  Files          46       46              
  Lines        7070     7080      +10     
==========================================
+ Hits         6050     6058       +8     
- Misses       1020     1022       +2     
Files with missing lines Coverage Δ
src/anndata/_io/specs/registry.py 94.50% <100.00%> (+0.02%) ⬆️
src/anndata/_settings.py 94.33% <100.00%> (+0.03%) ⬆️
src/anndata/_io/zarr.py 82.22% <75.00%> (-0.71%) ⬇️

@ilan-gold ilan-gold requested a review from flying-sheep August 29, 2025 09:30
Copy link
Member

@flying-sheep flying-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! don’t forget to add the issue tracking the removal to the next version’s milestone.

@ilan-gold ilan-gold enabled auto-merge (squash) August 29, 2025 10:35
@ilan-gold ilan-gold merged commit 220b2a6 into main Aug 29, 2025
18 checks passed
@ilan-gold ilan-gold deleted the ig/reallow_h5_slash_writing branch August 29, 2025 10:48
meeseeksmachine pushed a commit to meeseeksmachine/anndata that referenced this pull request Aug 29, 2025
flying-sheep pushed a commit that referenced this pull request Aug 29, 2025
@ilan-gold ilan-gold modified the milestones: 0.12.2, 0.12.3 Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request: Migration support for / character restriction in keys

2 participants