Skip to content

Conversation

jhaberbe
Copy link
Contributor

Updated the rankby_obsm function to optionally accept keys to test as an argument.

Copy link
Collaborator

@PauBadiaM PauBadiaM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhaberbe looks good! If you don't mind, could you also add a small description of the new argument in the docstring? Thanks!

@jhaberbe
Copy link
Contributor Author

Hiya, just added it.

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 94.95%. Comparing base (545c96a) to head (a492d45).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
src/decoupler/tl/_rankby_obsm.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
+ Coverage   94.90%   94.95%   +0.04%     
==========================================
  Files          76       76              
  Lines        3929     3927       -2     
==========================================
  Hits         3729     3729              
+ Misses        200      198       -2     
Files with missing lines Coverage Δ
src/decoupler/tl/_rankby_obsm.py 97.82% <50.00%> (-2.18%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jhaberbe
Copy link
Contributor Author

It looks like its failing when pulling up the example datasets:

dc.ds.msvisium()
dc.ds.hsctgfb()

and it seems to be expecting gzip'd file formats for some of the dataframes? I don't know why updating the pyproject and changelog would cause that.

after looking at the link for: https://pubmed.ncbi.nlm.nih.gov/static-page/down_bethesda.html?acc=GSE151251&format=file&file=GSE151251%5FHSCs%5FCtrl%2Evs%2EHSCs%5FTGFb%2Ecounts%2Etsv%2Egz

it looks like the site is down for maintenance. I captured a web-archive of it here. Crazy bad luck, lol.

https://web.archive.org/web/20250726190035/https://pubmed.ncbi.nlm.nih.gov/static-page/down_bethesda.html?acc=GSE151251&format=file&file=GSE151251%5FHSCs%5FCtrl%2Evs%2EHSCs%5FTGFb%2Ecounts%2Etsv%2Egz

I guess just wait until later tomorrow, and try it again?

@PauBadiaM PauBadiaM merged commit aeb6953 into scverse:main Jul 27, 2025
46 of 56 checks passed
@jhaberbe jhaberbe deleted the issue-225 branch October 14, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants