-
Notifications
You must be signed in to change notification settings - Fork 113
Add tiling QC metric for tile-boundary segmentation artifacts #1157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
timtreis
wants to merge
27
commits into
main
Choose a base branch
from
feature/tiling-qc-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
472d169
Add tiling QC metric for detecting tile-boundary segmentation artifacts
timtreis 8020a1e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] de15686
Increase fixture density, pin spatialdata-plot>=0.3.3
timtreis c1636a1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] d86fafb
Numba-accelerate collinearity scan, fix progress bar, vectorise helpers
timtreis 801546b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 6bb7f2a
Trim tests to core behavioural + visual, add cardinal alignment visual
timtreis 7613f60
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 4511c7c
Replace joblib with dask.delayed, add affinity-aware cpu_count
timtreis edbe8df
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 011c9c9
Remove comments that restate what code already says
timtreis 630287e
Default to PowerNorm(gamma=0.5) in tiling QC plot
timtreis 68fdf54
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 51db659
Fix ruff C420: use dict.fromkeys for _NAN_SCORES
timtreis c7a2974
Regenerate visual references with PowerNorm(gamma=0.5)
timtreis 81385e2
Revert PowerNorm — keep linear colour scale for tiling QC plot
timtreis 4ecb3df
Regenerate visual references with linear colour scale
timtreis 1516ba3
Add spatial post-processing to tiling QC (smoothed_cut_score, is_outl…
timtreis 0f8fe54
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 2d3ab94
Use jittered-grid cell placement for denser test fixture (625 vs 120 …
timtreis 070a336
Enable colorbar in default tiling QC plot, test with bare defaults
timtreis be32f07
Dual-gate outlier detection (cut_score + smoothed) with human-friendl…
timtreis 1ce365e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 1ccb020
Add visual test for is_outlier boolean flag
timtreis 8642327
Merge branch 'main' into feature/tiling-qc-v2
timtreis 86ee0b0
Address review: tile-spec loop, fail-fast validation, n_neighbors par…
timtreis a8bea24
Merge branch 'main' into feature/tiling-qc-v2
timtreis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this change unrelated to this PR? Do we really need it? Like have you seen os.cpu_count cause errors so far?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update: I now remember _get_n_cores. Why don't we modify that one instead?