chore: add flaky marker to pyproject#1179
Open
selmanozleyen wants to merge 3 commits into
Open
Conversation
flying-sheep
requested changes
May 15, 2026
Member
There was a problem hiding this comment.
The dependency isn’t called flaky, it’s pytest-rerunfailures. And the marker section is only for markers we add, plugins will register their markers:
- pytest will discover and load the plugin if the package is installed: https://github.com/pytest-dev/pytest-rerunfailures/blob/9f792d9efe6bf0218e7ba2734257af2d5165ca3f/pyproject.toml#L48
- the plugin will register the marker: https://github.com/pytest-dev/pytest-rerunfailures/blob/9f792d9efe6bf0218e7ba2734257af2d5165ca3f/src/pytest_rerunfailures.py#L343-L350
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1179 +/- ##
=======================================
Coverage 73.82% 73.82%
=======================================
Files 45 45
Lines 7013 7013
Branches 1188 1188
=======================================
Hits 5177 5177
Misses 1349 1349
Partials 487 487 🚀 New features to boost your workflow:
|
Member
Author
But this means we got flaky from somewhere else because pytest-rerunfailures takes |
flying-sheep
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
similar to the gpu marker we needed to add even though the CI's worked here: #1140. We need to add the flaky marker explicitly here.