Fix session leak in PeersV2NodeRefreshIT test #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bouncheck
reviewed
May 3, 2024
PeersV2NodeRefreshIT#should_successfully_send_peers_v2_node_refresh_query integration test does not close its test session, leading to leaks when integration tests suite is executed in CI. This affects SessionLeakIT#should_warn_when_session_count_exceeds_threshold test, which sees the leaked session and fails due to an unexpected number of active sessions. The change wraps the test in try-with block so that the test session is autoclosed at the end, preventing it from affecting subsequent tests.
dimakr
force-pushed
the
PeersV2NodeRefreshIT_session_leak
branch
from
dbab958 to
bea9b3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PeersV2NodeRefreshIT#should_successfully_send_peers_v2_node_refresh_queryintegration test does not close its test session, leading to leaks when integration tests suite is executed in CI. This affectsSessionLeakIT#should_warn_when_session_count_exceeds_thresholdtest, which sees the leaked session and fails due to an unexpected number of active sessions.The change adds post-test cleanup in
PeersV2NodeRefreshITto ensure that session is properly closed after the test, preventing it from affecting subsequent tests.