[Backport 2025.1] fix(enable_default_filters): move DB event filter for raft error to default filters#10738
Merged
vponomaryov merged 1 commit intoscylladb:branch-2025.1from Apr 29, 2025
Conversation
…efault filters PR scylladb/scylla-cluster-tests/scylladb#10386 filter some expected raft error messages globally. But this change broke integration unit test. Issue scylladb#10676. Move DB event Filter from `ignore_topology_change_coordinator_errors` context manager to `enable_default_filters`. If the event will be filtered globally, then no need to filter it with cm. Fixes scylladb#10676 (cherry picked from commit 987afc1)
vponomaryov
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR scylladb/scylla-cluster-tests/#10386 filter some expected
raft error messages globally. But this change broke integration
unit test. Issue #10676.
Move DB event Filter from
ignore_topology_change_coordinator_errorscontext manager to
enable_default_filters. If the event will befiltered globally, then no need to filter it with cm.
Fixes #10676
Testing
PR pre-checks (self review)
backportlabelsReminders
Add New configuration option and document them (in
sdcm/sct_config.py)Add unit tests to cover my changes (under
unit-test/folder)Update the Readme/doc folder relevant to this change (if needed)
(cherry picked from commit 987afc1)
Parent PR: #10694