Skip to content

fix(nodetool rebuild): use repair instead of rebuild if no tablets support #9073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
yarongilor wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix(nodetool rebuild): use repair instead of rebuild if no tablets support #9073

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 32 additions & 6 deletions sdcm/nemesis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4114,12 +4114,26 @@ def decommission_post_action():
timeout=full_operations_timeout):

ParallelObject(objects=[trigger, watcher], timeout=full_operations_timeout).call_objects()
is_rebuild_supported = SkipPerIssues('scylladb/scylladb#17575', params=self.tester.params)
should_workaround_rebuild = is_tablets_feature_enabled(self.target_node) and not is_rebuild_supported
if new_node := decommission_post_action():
new_node.wait_node_fully_start()
new_node.run_nodetool("rebuild", long_running=True, retry=0)
# If tablets in use and rebuild is not supported, running a DC repair instead.
if should_workaround_rebuild:
for node in [n for n in self.cluster.nodes if
n.dc_idx == new_node.dc_idx and n.db_up()]:
node.run_nodetool(sub_cmd="repair", long_running=True, retry=0)
else:
with adaptive_timeout(Operations.REBUILD, self.target_node, timeout=HOUR_IN_SEC * 48):
new_node.run_nodetool("rebuild", long_running=True, retry=0)
else:
self.target_node.wait_node_fully_start()
self.target_node.run_nodetool(sub_cmd="rebuild", long_running=True, retry=0)
if should_workaround_rebuild:
for node in [n for n in self.cluster.nodes if
n.dc_idx == self.target_node.dc_idx and n.db_up()]:
node.run_nodetool(sub_cmd="repair", long_running=True, retry=0)
else:
self.target_node.run_nodetool(sub_cmd="rebuild", long_running=True, retry=0)

def start_and_interrupt_repair_streaming(self):
"""
Expand Down Expand Up @@ -4147,8 +4161,14 @@ def start_and_interrupt_repair_streaming(self):

self.target_node.wait_node_fully_start()

with adaptive_timeout(Operations.REBUILD, self.target_node, timeout=HOUR_IN_SEC * 48):
self.target_node.run_nodetool("rebuild", long_running=True, retry=0)
is_rebuild_supported = SkipPerIssues('scylladb/scylladb#17575', params=self.tester.params)
# If tablets in use and rebuild is not supported, running a DC repair instead.
if is_tablets_feature_enabled(self.target_node) and not is_rebuild_supported:
for node in [n for n in self.cluster.nodes if
n.dc_idx == self.target_node.dc_idx and n.db_up()]:
node.run_nodetool(sub_cmd="repair", long_running=True, retry=0)
with adaptive_timeout(Operations.REBUILD, self.target_node, timeout=HOUR_IN_SEC * 48):
self.target_node.run_nodetool("rebuild", long_running=True, retry=0)

def start_and_interrupt_rebuild_streaming(self):
"""
Expand Down Expand Up @@ -4178,8 +4198,14 @@ def start_and_interrupt_rebuild_streaming(self):
)
ParallelObject(objects=[trigger, watcher], timeout=timeout + 60).call_objects()
self.target_node.wait_node_fully_start(timeout=300)
with adaptive_timeout(Operations.REBUILD, self.target_node, timeout=HOUR_IN_SEC * 48):
self.target_node.run_nodetool("rebuild", long_running=True, retry=0)
is_rebuild_supported = SkipPerIssues('scylladb/scylladb#17575', params=self.tester.params)
# If tablets in use and rebuild is not supported, running a DC repair instead.
if is_tablets_feature_enabled(self.target_node) and not is_rebuild_supported:
for node in [n for n in self.cluster.nodes if
n.dc_idx == self.target_node.dc_idx and n.db_up()]:
node.run_nodetool(sub_cmd="repair", long_running=True, retry=0)
with adaptive_timeout(Operations.REBUILD, self.target_node, timeout=HOUR_IN_SEC * 48):
self.target_node.run_nodetool("rebuild", long_running=True, retry=0)

def disrupt_decommission_streaming_err(self):
"""
Expand Down