fix: make include patterns additive to source detection #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix include patterns not working for non-source file types (e.g., *.peb) - Refactor filtering logic into centralized should_process_file() function - Implement union behavior: files match if source OR include patterns match - Add comprehensive test coverage for pattern interactions and edge cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: The
-i/--includeflag didn't work for file types that failed source detection (e.g.,glimpse . -i "*.peb"returned zero files even when .peb files existed).Root Cause:
source_detection::is_source_file()filtered out files before include patterns were evaluated, making it impossible to include non-source file types.Solution: Refactored filtering logic to make include patterns additive to source detection, matching the CLI help text ("Additional patterns to include"). Files are now included if they match either source detection OR include patterns, then exclude patterns are applied to the union.
Changes:
should_process_file()functionmatches_include_patterns()andmatches_exclude_patterns()functions(source_detection OR include_patterns) AND NOT exclude_patterns