-
-
Notifications
You must be signed in to change notification settings - Fork 489
feat: Added music support through Lidarr #1238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
|
@0-Pierre do not merge develop into this PR. Rebase on develop instead. Could you please rebase and remove all theses merge commits? |
Apologies, I'm not very familiar with the GitHub processes and features. I'll do my best, but the first commit was automatically created during a rebase when I used the "Rebase current branch..." option. |
|
A preview for this feature is available as (In about 15-20 mins) |
|
Hi! I briefly tested the PR. Great work!
Thank you again for the work! |
@AlessandroTischer Hey! Thanks for your notes, here's some points : On my end, I’m using it in production with all my users, and so far, I haven’t encountered any major bugs or errors causing server crashes. I’ll continue monitoring the logs. 👀 🔥 |
|
Hey, @0-Pierre just popping by to say awesome work! It's fun to finally be able to play around with music requests, even though it's just a preview. Sharing some additional feedback as a Plex/Jellyseerr user:
Unmonitoring either the artist/album and making the request again results with the same error. The only work around that I've found so far is to remove the artist altogether from Lidarr and request it again. That way, it get added to Lidarr the way you described above; however, the following is observed:
Additionally, the artist gets added to Lidarr without a metadata profile; unsure if that is expected behavior. For context, I am running everything on Windows 11 and have tried using both the official Lidarr service as well as with Once again, thanks for putting in the work and time to make this! |
@gssariev Thank you for your tests! I actually haven't tested it in a Plex setup situation yet. I'll review all the issues you reported and will get back with a commit to fix them. 😉 |
|
@0-Pierre great work so far, I was hoping one day we would get this added. Some items I am seeing so far; Running in docker with emby "play on" not showing for available media player |
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should only have the en.json using the pnpm i18n:extract for the i18n locales. The rest of the translation strings should be updated through weblate.
Could you remove those translation files and rebase?
Sure, i'm fixing all the requested issues and I'll take care of that 👍 |
|
@gssariev Hello! I'll be pushing a new commit that resolves all the Plex-related issues. However, I'm having trouble reproducing your other issues, as everything seems to be working perfectly on my end — requests are sent and downloaded properly. I even set up a Plex test server, and everything is running smoothly with the same Docker version you're using. I've also implemented proper mapping for the Plex music library since Plex doesn't handle it like other libraries. They rely solely on release IDs, so we’re now mapping those to release-group IDs to ensure the database gets the correct entries. Gotta love Jellyfin for handling things more consistently in this area, lol. Let me know if you encounter any additional issues! |
Excited to test it out and will report any finding once available! The Lidarr issue could also be something on my end... |
|
@0-Pierre I built the image from your repository (unsure if that's the best approach), and I can confirm that my Music library does get detected and everything is being synced up, and is reflected in Jellyseerr. From the logs, I can also see that it correctly identifies some of my music as not having a MusicBrainz ID, which I expected as that music doesn't have an entry in their database - all good here. When it comes to Lidarr...it's a bit of a mixed bag and I think the issues mainly stem from the Running the official Lidarr service, with a bunch of indexers, seems to work better and is more consistent with what you described (initial delay of X seconds, unmonitored album, etc.); however, if the album requested is already monitored, the request screen gets stuck in a loop, but I get the same message as you in the logs and nothing else:
Ultimately, the request doesn't go through in that case. If I restart the container I can see it displayed as 'pending'. |
|
Hi @0-Pierre. Thanks for you great work! I've just set it up, but all my requests are failing with the error "Metadata profile does not exist": As I've just setup lidarr and I'm new to it, it might could just be a configuration issue within lidarr. Edit: It works, when I select the quality profile "Any", but not with any other profile. |
|
Just wanted to leave a comment that I am running this PR without any issues. Everything seems to work, just waiting for Lidarr to fix their metadata issues which should hopefully be soon. Will continue to run this PR and watch for issues. Excited to see this officially added. https://www.reddit.com/r/Lidarr/comments/1ktitdq/searching_for_new_artists_failedunable_to/?sort=new |
|
looks like lidarr has fixed things... |
No they haven't. I've been getting a lot of these failures today, and even using the MB ID has only been 50% successful. |
Not to get too far off topic here, but Lidarr has rolled out the fix to their metadata servers. They have to ease into it (currently only 1% of un-cached requests goto the new servers) and build up the metadata cache, or the millions of lidarr requests will bring the new servers down. So the fix is in production, it's just going to take some weeks/months of building up the cache before they can crank the lever up to 100%. More artists and albums get added to the cache every hour, so it's just a matter of time. Hitting Refresh Artists in your Lidarr tasks a few times a day will help get Your artists/albums in the cache sooner, but still expect that to take a few weeks. Otherwise it will still happen just less often, as Lidarr automatically does that task once a day. |
|
hi, here to say the same thing as Tiddly. using it without any issues except covers not being loaded which I suspect is because it relies on lidarr's metadata service (and 32bit int bug on permissions), . I have an external metadata provider and the request pipeline is a smooth as it can get. Could be nice to actively separate each section for a search considering Music is now flooding Movies/Series and vice versa. |
Permissions issue is fixed here ^ |
|
From what I've read there doesn't seem to be any separation between music searches and movie/TV searches, is that something that's planned? |
Is there something wrong with my config? Why doesn't the music tab show a single thing, or is this expected behavior at this point? |
Can't reproduce. Only Music DB is missing in slider config, but I think this will come later. The existing sliders (album...) are working as expected. But guys this is still WIP. Don't expect something to work as expected. You are on a feature/dev branch and by definition they can break. Wait for offical release and then report bugs. |
|
Minor bug. When managing Jellyseerr user permissions, if the Manage Requests permission is added to a user, that user is also supposed be granted Auto-Approve, Auto-Approve Movies, Auto-Approve Series, and Auto-Approve Books. However, at least on Chrome, it does not automatically add Auto-Approve Music, so the user still has to manually add that one whereas all the other auto-approve permissions were granted automatically. |
|
I came straight the moment i read this. |
|
Just for the avoidance of doubt here, this isn't expected to work with readarr at all (albeit an instance set up for audiobook-only management)? This PR seems to support successfully adding the readarr instance (non-default in my case), searching and other actions right through to the actual (failing) request action Otherwise, already very thankful for the lidarr support. Works well in my limited testing 👏 E2A i see another ebook support PR |
|
I've been so happy that Lidarr has been returned to most of its functionality, that I forgot about this for a moment. I successfully requested an album with Jellyseerr, and it was grabbed and imported via Lidarr. Woo! Just curious, what are the road blocks in getting this very functional PR merged to the main branch here? |
|
I hope this will be the first thing after the jellyseerr and overseerr merge into seerr.... @sct what is your opinion? |
|
This looks great. What is the status of getting this mainlined? |
|
If this works indeed please get it Rebased at least with the latest changes, its a NEED! |
|
I have been running this build with no problems for the last 4 months. It's ready to go imo. |
Just curious, I presume you built your own image based off of this branch? If not, is there an image floating around that someone could pull to test this out? |
|
From this thread, there is this image tag -> |
Excellent. Thanks @baudneo. |
|
Still a time frame for merging would be nice, I'm waiting for this and the SSO integration to be merged before I can deploy jellyseer. |
|
It’s free software so please just be patient. They don’t owe you anything. Maybe this will never be merged and that’s fine. |
|
Also a gentle reminder that everytime you comment on a Github PR it emails everyone who has participated or followed that PR. So let's keep the comments relevant to the code and not a bunch of "me too!" spam, please. |
|
Super excited to learn Lidarr integration is being worked on! I setup a fresh install of the https://jellyseerr.yazdani.au/api/v1/discover/music?page=1&days=7 is throwing: From Docker logs: |







Description
Jellyseerr fully support music trough Lidarr 🚀 🎵
Metadata
We’re using the Lidarr API (api.lidarr.audio) to improve speed, as MusicBrainz (MB) often suffers from high latency and server overload issues.Trade-off: The results are slightly less precise compared to the MB Search API.
Overview
The overview section pulls data from Wikipedia, ensuring multilingual support for more flexible and accurate descriptions.
Image Handling
Images are initially loaded from the provided links and cached locally.
The Lidarr API offers additional artist images that aren’t available in the Cover Art Archive (CAA).If an image is missing, the system automatically falls back to CAA.
Caching
By default, images from CAA and Fanart are cached locally, as these sources tend to load slowly.
Cached images are stored in the /cache folder and can be cleared via the settings page using a dedicated job.
Other images are only cached if specific options are enabled.
Similar Artists / Trending
We use the ListenBrainz API to provide recommendations for similar artists and trending music. Missing images are completed through the Lidarr API, with a fallback to CAA.
Artist Groups
The /group endpoint is dedicated to artist groups (bands). For individual artists (persons), we merge data with the /person endpoint from TMDb to avoid duplicate entries.
Informations Points
There are cases where images aren’t available on either the CAA or the
Lidarr API. In such instances, we need to upload them to the MusicBrainz database to ensure they are displayed. This aligns with the core purpose of MusicBrainz, a community-driven platform for sharing metadata.For this reason, I’ve removed Deezer as a fallback. Encouraging community contributions is more in line with MusicBrainz’s philosophy. Additionally, using Deezer’s fallback wasn’t always reliable, as the matching wasn’t based on precise IDs, though it worked correctly about 95% of the time.
Screenshot (if UI-related)
To-Dos
pnpm buildpnpm i18n:extractIssues Fixed or Closed