-
-
Notifications
You must be signed in to change notification settings - Fork 489
feat: music support #2132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
feat: music support #2132
Conversation
|
Little bits to fix up, but its mostly working again against the new code. I am trying to reduce some of the changes though, I feel like it touches and changes more than it needs to in some places. Any feedback helpful. All credit to @0-Pierre for 99% of the work. |
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
|
This is kinda off topic but if you want you can add at end of the commit message Also might be good practice to rebase commit a commit or just clone the branch and update from there. Bellow is a clean way of getting the old branch on your repo: git checkout -b lidarr-bk lidarr #saves your branch
git branch -D lidarr
git remote add 0pierre https://github.com/0-Pierre/jellyseerr.git
git fetch 0pierre
git checkout -b lidarr origin/0pierre |
|
Thank you! I did have a really nice rebase that included all of pierre's commit history, then my lack of git expertise caused me to fumble and nuke it all. I'll try and get it back with that :) |
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
… and applied prettier to migration file
…operly display artist name in the slide-over menu
…ensured media are properly removed from Lidarr.
…new architecture This was using an older architecture for the notifications and request, this change updates the system to match how movies and tv are done
…ULL constraint failure in metadata_album.caaUrl
…repo develop branch
…h AddMusicSupport
separted the discography and similar-artist from the monolithic artists call
Music was being blacklisted, and the API call to listenbrainz was wrong
Aligned the request notifications with radarr and sonarr, which fixed how it used updateParentStatus
|
Eyyy got it back! |
Indeed, if you feel like things can be removed/refactored to reduce the number of changes, please do. |
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
|
Hello, Why is there a need to supersede PR #1238 ? In his last message, 0-Pierre confirmed he is still available to work on until we (Seerr) are ready for it. |
|
Hi everyone, To be honest I'm pretty happy someone with an other vision refactor the code, I'm very busy and don't have that much time this last 6 months. So enjoy, let's makes Seerr even better 👍 |
|
Thanks for your quick feedback @0-Pierre I can close your PR in favor of this one so :) |
Description
This is 99% https://github.com/0-Pierre 's branch (#1238), all credit to them!
Haven't had any action on the other PR for a while, so this is a re-based + updated PR based on that PR.
Screenshot (if UI-related)
To-Dos
pnpm buildpnpm i18n:extractIssues Fixed or Closed
Please use this discussion #2160 as a place to discuss testing / questions related to the work-in-progress Music support feature. This will allow the PR comments to be used for code review instead of general discussion.