toPng fix #1454
Open
toPng fix #1454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ^2.0.0 method image .toPng is called .toPNG see: https://github.com/electron/electron/blob/master/docs/api/native-image.md#imagetopngoptions
|
Can anyone please review this PR? its stopping from upgrading to newer versions of electron. |
wojtekmaj
reviewed
Sep 16, 2018
| done(null, img.toPNG()); | ||
|
|
||
| } else { | ||
| done(new Error('no png method found in electrons image.')); |
There was a problem hiding this comment.
I think that's what we have package.json for is to be sure this will never happen.
So, we could have it in one line:
const toPng = img.toPng || img.toPNG;
done(null, toPng());If you really think that's necessary, between line 1 and 2 you could add
if (!toPng) {
done(new Error('Neither toPng nor toPNG method was found in Electron\'s image.'));
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In electron ^2.0.0 method image .toPng is called .toPNG
see: https://github.com/electron/electron/blob/master/docs/api/native-image.md#imagetopngoptions