Skip to content

toPng fix #1454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

toPng fix #1454

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion lib/runner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,16 @@ app.on('ready', function() {
// https://gist.github.com/twolfson/0d374d9d7f26eefe7d38
var args = [
function handleCapture(img) {
done(null, img.toPng())
if(img.toPng) {
done(null, img.toPng());

} else if(img.toPNG) {
// @see https://github.com/electron/electron/blob/master/docs/api/native-image.md#imagetopngoptions
done(null, img.toPNG());

} else {
done(new Error('no png method found in electrons image.'));
Copy link

@wojtekmaj wojtekmaj Sep 16, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's what we have package.json for is to be sure this will never happen.

So, we could have it in one line:

const toPng = img.toPng || img.toPNG;
done(null, toPng());

If you really think that's necessary, between line 1 and 2 you could add

if (!toPng) {
    done(new Error('Neither toPng nor toPNG method was found in Electron\'s image.'));
}

}
}
]
if (clip) args.unshift(clip)
Expand Down