Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add sasl-secrets-manager-arn to shared opts #225

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

petedannemann
Copy link
Contributor

@petedannemann petedannemann commented Mar 6, 2025

Several subcommands use a subset of the config options and sasl-secrets-manager was not included there. This should also fix #205

@petedannemann petedannemann marked this pull request as ready for review March 6, 2025 16:46
@petedannemann petedannemann requested a review from a team as a code owner March 6, 2025 16:46
@petedannemann petedannemann merged commit 783435a into master Mar 6, 2025
8 checks passed
@petedannemann petedannemann deleted the fix/apply-secrets-manager branch March 6, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply command not reading credentials from AWS Secrets manager without placeholder in cluster config
2 participants