Fix mis-configured grid for <ul>s inside definitions #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4shub
changed the title
This was referenced Sep 7, 2020
Collaborator
|
Thank you, @4shub! I love how detailed your PR is. I think in this case the solution proposed in #271 fixes an additional problem of the countries list being less scannable (which was a prior issue, and not your fault). Re: this as a general list problem, I think fixing the inheritance as in #347 will solve this problem in a more global way. For now I'm going to mark this as duplicative. I really hope you'll submit again soon! |
tatianamac
added
Resolution · Duplicate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR was made to fix the following UI issue found here
Before
After
Details
It looks like only paragraph level list items have the
grid-columnconfiguration css included. This adds thegrid-columnattribute to anyulitem that's a direct child of the definition content.note: Not sure if this app might benefit if all "block" items should receive this
grid-columntreatment. But for now this change should fix the visual blip.