Skip to content

Conversation

@ajtran303
Copy link

@ajtran303 ajtran303 commented Sep 8, 2020

This PR will close #271

This enhances the layout of the countries listed in the definition for Southeast Asian by using two columns.

Screenshots before and after:
Screen Shot 2020-09-07 at 6 49 43 PM
Screen Shot 2020-09-07 at 7 04 01 PM

First, I changed the markdown to have better ease of reading:

  • Adds h3 headings to Mainland / Maritime sub-regions
  • Each country is now a list item element

Then, I added new CSS rules.

& h3 ~ ul {
  border-bottom: 0.1rem solid lightgrey;
  padding-bottom: 1rem;
}

Future definitions can use this new layout by following this Markdown example:

### Sandwich Condiments

- Mayonaise
- Mustard

### Pasta Sauces

- Marinara
- Pesto

Or this HTML example:

<h3>Sandwich Condiments</h3>

<ul>
  <li>Mayonaise</li>
  <li>Mustard</li>
</ul>

<h3>Pasta Sauces</h3>

<ul>
  <li>Marinara</li>
  <li>Pesto</li>
<ul>

@ajtran303
Copy link
Author

Reviewers be aware: #321 has another approach to solving this as well!

Copy link
Collaborator

@tatianamac tatianamac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment.

}

& h3 ~ ul {
border-bottom: 0.1rem solid lightgrey;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
border-bottom: 0.1rem solid lightgrey;
border-bottom: 0.1rem solid lightgrey;

Could we use one of our sass variable colours here so that the change will respect light-dark mode?

@tatianamac tatianamac added Type · Bug Something isn't working Type · Frontend Frontend work labels Oct 7, 2020
@ajtran303
Copy link
Author

Just an update on this: I'm finishing up school and focusing on graduating but after this I will come back and then work in this and get more involved in the API side too :)

@tatianamac
Copy link
Collaborator

Thanks for the update @ajtran303. Best of luck with school! We'll be here when you're ready.

ajtran303 and others added 4 commits November 19, 2020 13:15
Update local prod with prod prod
* Adds h3 headings to Mainland / Maritime sub-regions

* Each country is now a list item element
This commit enhances the layout of the countries listed
in the definition for Southeast Asian by using two columns.

Future definitions can use this new layout
by following this Markdown example:

  ### Sandwich Condiments
  - Mayonaise
  - Mustard

  ### Pasta Sauces
  - Marinara
  - Pesto
@tatianamac
Copy link
Collaborator

@ajtran303 Is this good to merge in from your perspective?

@ajtran303
Copy link
Author

ajtran303 commented Nov 20, 2020

@ajtran303 Is this good to merge in from your perspective?

@tatianamac Hi! This is good to merge in :)

This may not be necessary to merge in, as there have been some styling updates that affect the need for this code.

@ajtran303 ajtran303 marked this pull request as draft December 19, 2020 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status · In Progress Type · Bug Something isn't working Type · Frontend Frontend work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Broken List Display in Southeast Asian Definition

2 participants