-
-
Notifications
You must be signed in to change notification settings - Fork 169
Adjusts Southeast Asian countries list #322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: prod
Are you sure you want to change the base?
Conversation
|
Reviewers be aware: #321 has another approach to solving this as well! |
tatianamac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment.
| } | ||
|
|
||
| & h3 ~ ul { | ||
| border-bottom: 0.1rem solid lightgrey; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| border-bottom: 0.1rem solid lightgrey; | |
| border-bottom: 0.1rem solid lightgrey; |
Could we use one of our sass variable colours here so that the change will respect light-dark mode?
|
Just an update on this: I'm finishing up school and focusing on graduating but after this I will come back and then work in this and get more involved in the API side too :) |
|
Thanks for the update @ajtran303. Best of luck with school! We'll be here when you're ready. |
Update local prod with prod prod
* Adds h3 headings to Mainland / Maritime sub-regions * Each country is now a list item element
This commit enhances the layout of the countries listed in the definition for Southeast Asian by using two columns. Future definitions can use this new layout by following this Markdown example: ### Sandwich Condiments - Mayonaise - Mustard ### Pasta Sauces - Marinara - Pesto
73d8624 to
c0b0565
Compare
|
@ajtran303 Is this good to merge in from your perspective? |
@tatianamac This may not be necessary to merge in, as there have been some styling updates that affect the need for this code. |
This PR will close #271
This enhances the layout of the countries listed in the definition for Southeast Asian by using two columns.
Screenshots before and after:


First, I changed the markdown to have better ease of reading:
Then, I added new CSS rules.
Future definitions can use this new layout by following this Markdown example:
Or this HTML example: