feat: new policy view with login CTA #186
Draft
+71
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The policy view is blank on logging in. This still version of this commit needs some imports updated. Planning on going through and reorganizing imports generally / improving autoformatting and then rebasing probably.
kopecs
commented
Dec 2, 2024
Comment on lines
+256
to
+259
| // TODO(cooper): This is an ugly hack to allow for easily updating the login | ||
| // status. It is rather fragile and we should instead do this by cleaning up | ||
| // the LSP extensions we use for login. However, this lets us ensure we have | ||
| // reasonably up-to-date UI state until then. |
There was a problem hiding this comment.
To be updated per our discussion but I would like to merge this in the interim.
|
screenshots? |
ajbt200128
reviewed
Dec 2, 2024
| return element; | ||
| } | ||
|
|
||
| getChildren( |
There was a problem hiding this comment.
what's the source for this data?
There was a problem hiding this comment.
Oh whoops; sorry there should be placeholder text (essentially just "you're logged in") here in this version. I have more in a future (wip) PR.
|
I'm going to move this back to draft while I update the login flow stuff we discussed since it is causing some cases where the UI would be stale here for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The policy view is blank on logging in. This still version of this commit needs some imports updated. Planning on going through and reorganizing imports generally / improving autoformatting and then rebasing probably.
PR checklist:
If you're unsure about any of this, please see: