Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: policy configuration for local config #199

Merged
merged 2 commits into from
Feb 6, 2025
Merged

feat: policy configuration for local config #199

merged 2 commits into from
Feb 6, 2025

Conversation

kopecs
Copy link
Contributor

@kopecs kopecs commented Feb 6, 2025 •
edited
Loading

PR checklist:

  • Purpose of the code is evident to future readers
  • Tests included or PR comment includes a reproducible test plan
  • Documentation is up-to-date
  • A changelog entry was for any user-facing change
  • Change has no security implications (otherwise, ping security team)

If you're unsure about any of this, please see:

Test plan: manual

This was referenced Feb 6, 2025
Merged
Merged
@kopecs Graphite App
Copy link
Contributor Author

kopecs commented Feb 6, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kopecs kopecs requested a review from ajbt200128 February 6, 2025 18:12
ajbt200128
ajbt200128 reviewed Feb 6, 2025
View reviewed changes
Copy link
Contributor

@ajbt200128 ajbt200128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screenshots plz

@kopecs Graphite App
Copy link
Contributor Author

kopecs commented Feb 6, 2025 •
edited
Loading

Merge activity

  • Feb 6, 2:40 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Feb 6, 2:42 PM EST: Graphite couldn't merge this pull request because a downstack PR feat: only show sign in/out as relevant #187 failed to merge.
  • Feb 6, 3:00 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Feb 6, 3:00 PM EST: A user merged this pull request with Graphite.

@kopecs kopecs force-pushed the cooper/code-7795-a branch from 6d5334c to 62c6194 Compare February 6, 2025 19:58
@kopecs kopecs changed the base branch from cooper/code-7796 to graphite-base/199 February 6, 2025 19:59
@kopecs
feat: policy configuration for local config
6d595e6 
If the user isn't logged in, also show an option for a local config.
Extends the policy view in either case to list local configurations too.
@kopecs kopecs force-pushed the graphite-base/199 branch from 50ded7c to 720c788 Compare February 6, 2025 19:59
@kopecs kopecs force-pushed the cooper/code-7795-a branch from 62c6194 to 4eca3d0 Compare February 6, 2025 19:59
@kopecs kopecs changed the base branch from graphite-base/199 to develop February 6, 2025 20:00
@kopecs kopecs force-pushed the cooper/code-7795-a branch from 4eca3d0 to 9992ef2 Compare February 6, 2025 20:00
@kopecs kopecs merged commit 47fecb6 into develop Feb 6, 2025
8 of 10 checks passed
@kopecs kopecs deleted the cooper/code-7795-a branch February 6, 2025 20:00
@kopecs
Copy link
Contributor Author

kopecs commented Feb 6, 2025

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajbt200128 ajbt200128 ajbt200128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kopecs @ajbt200128