horiba_pentra_xlr: widen report_type to accept 'I' and fix CommentRecord.source tuple syntax#75
Merged
Merged
Conversation
ramonski
force-pushed
the
fix-pentra-xlr-set-tuples
branch
from
14dceef to
db004f8
Compare
…ord.source tuple syntax
ramonski
force-pushed
the
fix-pentra-xlr-set-tuples
branch
from
db004f8 to
0ba6702
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
Audit of
horiba_pentra_xlragainst the Horiba Pentra XLR ASTM interface manual surfaced two small schema issues in the Order and Comment records.Current behavior before PR
OrderRecord.report_typeis aSetField(values=("F", "C")). Spec 9.4.26 (Note 4) also listsI(Result unvalidated, used when unconditional validation is off).Iis logged as unexpected at parse time.CommentRecord.sourceis declaredSetField(values=("I")). Because("I")is a string, not a tuple, the SetField allow-list silently becomesset('I')— equivalent to a one-element tuple by accident, but semantically wrong and easy to break when a second value is added.Desired behavior after PR is merged
OrderRecord.report_typeaccepts('F', 'C', 'I').CommentRecord.sourceusesvalues=('I',)so the allow-list is unambiguous.