delay extract & update process of in-game download mechanism #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catizard
force-pushed
the
feat/delay_extract_after_downloading
branch
from
af23814 to
c411b21
Compare
seraxis
requested changes
Sep 23, 2025
| if (main.getCurrentState() instanceof BMSPlayer) { | ||
| // Do nothing | ||
| } else if (!waitingExtractArchives.isEmpty()) { | ||
| main.setSuspendPlaySceneTransition(true); |
Owner
There was a problem hiding this comment.
This presents a serious issue to user experience, as we talked on discord we should have a scene or some indication that play is suspended
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #83, this pr delays the two steps after downloading file:
to reduce the performance impact when playing BMS
Here's a flame graph when trying to download bms at background while playing
