Update generated design docs#11490
Open
skiminki-nv wants to merge 5 commits into
Open
Conversation
Resolve the two findings deferred in the stage-3 remediation cycle: - name-resolution/visibility.md F-002: add slang-check-overload.cpp to the doc's watched_paths so its TryCheckOverloadCandidateVisibility citation is properly tracked, then regenerate the doc. This flips it to review-stale for the next review cycle. - target-pipelines/metal.md F-004: rebuild the Phase B diagram so every runtime conditional gate is a diamond node with true/false arms, per the target-pipeline diagram contract. Metal-constant gates are drawn as unconditional nodes per the filtered-branch convention. Refresh freshness.json via mark-fresh for both docs.
Out-of-band Stage 2 review (gpt-5.5) of the rebuilt metal.md Phase B diagram surfaced three major findings; remediate all three: - F-001: add the minimal-optimization branch passes that were missing from Phase B (eliminateDeadCode under minimalOptimization && generics; applySparseConditionalConstantPropagation + eliminateDeadCode under minimalOptimization), with matching diagram nodes and table rows. - F-002: redraw the shouldLegalizeExistentialAndResourceTypes false arm to run only the else-path legalizeEmptyTypes before rejoining. - F-003: reorder the Phase C table so legalizeIRForMetal precedes floatNonUniformResourceIndex, legalizeLogicalAndOr, and legalizeImageSubscript, matching source and the diagram. Records the review and remediation reports and updates the ledgers; metal.md returns to remediated.
Contributor
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (145)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The design docs were updated against commit 5233902 .