-
Notifications
You must be signed in to change notification settings - Fork 463
Make vertex-shader-missing-sv-position pedantic and off by default #11893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
expipiplus1
wants to merge
14
commits into
shader-slang:master
Choose a base branch
from
expipiplus1:push-zykknlllqkkv
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+409
−16
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
5c955fe
Add diagnostic warning levels (-Wall/-Wextra/-Wpedantic)
expipiplus1 f1a594d
Use keyword-used-as-name as the pedantic example; keep pedantic on by…
expipiplus1 081ffde
Address review: guard warning-level shift, make it additive, add test…
expipiplus1 0f8c787
Address re-review: doc staging note, direct include path
expipiplus1 a90b37a
Copy enabled warning groups into child sinks from their parent
expipiplus1 ab081c6
Add e2e directive combining -Wall/-Wextra/-Wpedantic on one command line
expipiplus1 fd14e7b
Regenerate command-line reference for -Wall/-Wextra/-Wpedantic
expipiplus1 97684a4
Make vertex-shader-missing-sv-position pedantic and off by default
expipiplus1 5af36ea
Fix warning-level unit test and comments for flipped defaults
expipiplus1 92bf080
Assert E38052 stays off under -Wall/-Wextra
expipiplus1 6fdcdcb
Note SLANG_WARNING_LEVEL_DEFAULT in WarningLevel option docs
expipiplus1 7a0db9e
Update generated diagnostics-catalog test for pedantic E38052
expipiplus1 fcc5e4c
Minimize hand-edit to generated 38052 catalog file
expipiplus1 66d1302
Reword E38052 message to avoid a run-on clause
expipiplus1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.