Skip to content

chore: Tidy up array pop() with subsequent re-push() #10099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avelad merged 1 commit into from
May 18, 2026
+3 −6
Merged

chore: Tidy up array pop() with subsequent re-push() #10099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/hls/hls_parser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4798,9 +4798,8 @@ shaka.hls.HlsParser = class {
} else if (bitrates.length) {
// It applies to every segment between it and the next EXT-X-BITRATE,
// so we use the latest bitrate value
const prevBitrate = bitrates.pop();
const prevBitrate = bitrates[bitrates.length - 1];
prevBitrate.duration += reference.endTime - reference.startTime;
bitrates.push(prevBitrate);
reference.bandwidth = prevBitrate.bitrate;
}

Expand Down
6 changes: 2 additions & 4 deletions lib/util/ts_parser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -771,10 +771,9 @@ shaka.util.TsParser = class {
if (!data) {
continue;
}
previousPes = this.audioPes_.pop();
previousPes = this.audioPes_[this.audioPes_.length - 1];
previousPes.data =
shaka.util.Uint8ArrayUtils.concat(previousPes.data, data);
this.audioPes_.push(previousPes);
}
}
}
Expand Down Expand Up @@ -806,10 +805,9 @@ shaka.util.TsParser = class {
if (!data) {
continue;
}
previousPes = this.videoPes_.pop();
previousPes = this.videoPes_[this.videoPes_.length - 1];
previousPes.data =
shaka.util.Uint8ArrayUtils.concat(previousPes.data, data);
this.videoPes_.push(previousPes);
}
}
if (naluProcessing) {
Expand Down
Loading