Skip to content

chore: Tidy up array pop() with subsequent re-push()#10099

Merged
avelad merged 1 commit into
shaka-project:mainfrom
absidue:array-pop-push
May 18, 2026
Merged

chore: Tidy up array pop() with subsequent re-push()#10099
avelad merged 1 commit into
shaka-project:mainfrom
absidue:array-pop-push

Conversation

@absidue

@absidue absidue commented May 17, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@google-cla

google-cla Bot commented May 17, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@shaka-bot

Copy link
Copy Markdown
Collaborator

Bundle Size Report for PR #10099

File HEAD Base Diff
controls.css 24.0 KiB (5.0 KiB) 24.0 KiB (5.0 KiB) 0.0 KiB
demo.compiled.debug.js 258.3 KiB (51.8 KiB) 258.3 KiB (51.8 KiB) 0.0 KiB
demo.compiled.js 258.3 KiB (51.8 KiB) 258.3 KiB (51.8 KiB) 0.0 KiB
demo.css 170.4 KiB (27.8 KiB) 170.4 KiB (27.8 KiB) 0.0 KiB
locales.js 43.6 KiB (10.8 KiB) 43.6 KiB (10.8 KiB) 0.0 KiB
receiver.compiled.debug.js 148.8 KiB (24.1 KiB) 148.8 KiB (24.1 KiB) 0.0 KiB
receiver.compiled.js 148.8 KiB (24.1 KiB) 148.8 KiB (24.1 KiB) 0.0 KiB
shaka-player.compiled-es2021.debug.js 1258.3 KiB (309.5 KiB) 1258.3 KiB (309.5 KiB) +0.0 KiB
shaka-player.compiled-es2021.js 666.4 KiB (222.3 KiB) 666.4 KiB (222.3 KiB) +0.0 KiB
shaka-player.compiled.debug.js 1530.5 KiB (350.6 KiB) 1530.4 KiB (350.6 KiB) +0.0 KiB
shaka-player.compiled.js 770.4 KiB (250.0 KiB) 770.4 KiB (250.0 KiB) +0.0 KiB
shaka-player.dash-es2021.debug.js 925.8 KiB (232.7 KiB) 925.8 KiB (232.7 KiB) +0.0 KiB
shaka-player.dash-es2021.js 460.0 KiB (157.0 KiB) 460.0 KiB (157.0 KiB) +0.0 KiB
shaka-player.dash.debug.js 1123.7 KiB (262.8 KiB) 1123.7 KiB (262.8 KiB) +0.0 KiB
shaka-player.dash.js 534.2 KiB (177.0 KiB) 534.2 KiB (177.0 KiB) +0.0 KiB
shaka-player.experimental-es2021.debug.js 1649.4 KiB (394.1 KiB) 1649.4 KiB (394.1 KiB) +0.0 KiB
shaka-player.experimental-es2021.js 919.4 KiB (291.4 KiB) 919.4 KiB (291.4 KiB) +0.0 KiB
shaka-player.experimental.debug.js 1985.8 KiB (444.2 KiB) 1985.8 KiB (444.2 KiB) +0.0 KiB
shaka-player.experimental.js 1045.4 KiB (324.9 KiB) 1045.4 KiB (324.9 KiB) +0.0 KiB
shaka-player.hls-es2021.debug.js 956.0 KiB (238.1 KiB) 956.0 KiB (238.1 KiB) +0.0 KiB
shaka-player.hls-es2021.js 492.9 KiB (167.0 KiB) 492.9 KiB (167.0 KiB) +0.0 KiB
shaka-player.hls.debug.js 1159.1 KiB (268.9 KiB) 1159.1 KiB (268.9 KiB) +0.0 KiB
shaka-player.hls.js 569.9 KiB (188.0 KiB) 569.9 KiB (188.0 KiB) +0.0 KiB
shaka-player.ui-es2021.debug.js 1566.9 KiB (376.7 KiB) 1566.9 KiB (376.7 KiB) +0.0 KiB
shaka-player.ui-es2021.js 878.9 KiB (279.9 KiB) 878.9 KiB (279.9 KiB) +0.0 KiB
shaka-player.ui.debug.js 1873.3 KiB (423.0 KiB) 1873.3 KiB (423.0 KiB) +0.0 KiB
shaka-player.ui.js 993.4 KiB (310.6 KiB) 993.4 KiB (310.6 KiB) +0.0 KiB

@shaka-bot

Copy link
Copy Markdown
Collaborator

Incremental code coverage: 66.67%

@avelad avelad added the type: code health A code health issue label May 18, 2026
@avelad avelad added this to the v5.2 milestone May 18, 2026
@avelad
avelad merged commit 12308b5 into shaka-project:main May 18, 2026
20 of 21 checks passed
@absidue
absidue deleted the array-pop-push branch May 18, 2026 07:22
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jul 17, 2026
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jul 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

status: archived Archived and locked; will not be updated type: code health A code health issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants