Skip to content

Update form configs#4587

Merged
IvanIlyichev merged 1 commit intoshesha-io:mainfrom
Lihlu:lihlulmise/form-updates
Mar 11, 2026
Merged

Update form configs#4587
IvanIlyichev merged 1 commit intoshesha-io:mainfrom
Lihlu:lihlulmise/form-updates

Conversation

@Lihlu
Copy link
Copy Markdown
Collaborator

@Lihlu Lihlu commented Mar 10, 2026

Epdated form configs for cs-folder-create, cs-notification-type-create, forgot-password, login, modules, registration and user-details

Summary by CodeRabbit

  • Chores
    • Updated configuration file handling in the application build process.

…-create, forgot-password, login, modules, registration and user-details

Co-Authored-By: KatlehoMadaba <101579604+KatlehoMadaba@users.noreply.github.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 5e14154e-a9c2-440a-9721-dd6a6c058889

📥 Commits

Reviewing files that changed from the base of the PR and between 7097309 and 6aea89f.

📒 Files selected for processing (2)
  • shesha-core/src/Shesha.Application/ConfigMigrations/package20260310_1617.shaconfig
  • shesha-core/src/Shesha.Application/Shesha.Application.csproj

Walkthrough

The change relocates a configuration migration package file (package20260310_1617.shaconfig) from the None Remove list to the EmbeddedResource Include list in the Shesha.Application project file, ensuring proper resource embedding.

Changes

Cohort / File(s) Summary
Project Configuration
shesha-core/src/Shesha.Application/Shesha.Application.csproj
Moved ConfigMigrations shaconfig file from None Remove to EmbeddedResource Include to ensure proper resource embedding.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • IvanIlyichev

Poem

🐰 A config file hops from None to light,
Embedded now, bundled just right,
Migration twenty-six takes flight—
Resources bundled, packaged tight! 📦✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Update form configs' is vague and generic, using non-descriptive language that doesn't convey meaningful information about which specific form configurations were updated or what changes were made. Consider a more specific title that references the actual forms updated (e.g., 'Update form configurations for folder creation, notifications, and user details') or the nature of the changes made.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Lihlu Lihlu marked this pull request as ready for review March 10, 2026 14:38
@Lihlu Lihlu requested a review from IvanIlyichev March 10, 2026 14:39
@IvanIlyichev IvanIlyichev merged commit 4479a26 into shesha-io:main Mar 11, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants