347 user following and followers change - #370
Open
Jordon1377 wants to merge 5 commits into
Open
Conversation
Buttons for follow and unfollow need to be fixed and reimplemented
Users can follow/unfollow on any profile page. The follower changes are fixed for the active user and changes to UI have been updated to only occur when on your own profile page. EX: Unfollowing removes entry from the list only on your own page now. Buttons are shown in correspondence to the active users followers and not the profile page users
***There are a few issues to fix: Unfollow and follow buttons could display in both menus based on whether the user is following them or not. Reloading the window is a temp fix. The use states should be ported into the popup files so that rather then reloading their states can be updated accordingly...
src/web/src/Components/profile/FollowerPopup.tsx src/web/src/Components/profile/FollowingPopup.tsx src/web/src/Pages/user/ProfilePage.tsx
Collaborator
Author
|
Pull from main broke something |
Collaborator
Author
|
Fixed issue |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following and Follower Pop up tabs in the profile menu now open for all users. The follow and unfollow buttons will act in accordance to the user opperating the site instead of the user whos page is being viewed. Currently the page reloads upon file. This takes a while and I will make an issue to fix it. In order to get around reloading the page, a bunch of use states and contexts will need to be sent to the pop up files so that they can be corrected uppon a user pressing follow or unfollow.