Merged
Conversation
BREAKING CHANGE: remove support for astro < v5.
shishkin
reviewed
Dec 6, 2025
| params as InternalHookParams; | ||
|
|
||
| addRenderer(astroJsx); | ||
| addRenderer({ name: "astro:mdx", serverEntrypoint: "@astrojs/mdx/server.js" }); |
Owner
There was a problem hiding this comment.
Wow! Is that really it?! I've tested it briefly and it seems to work. Let me just dig into mdx renderer internals to see if my hacky code below still makes sense with it.
Owner
|
Yeah, dropping support for Astro < v5 is fine in a new major version. |
Owner
|
I've tested it in SSR mode with Node adapter. The generated code looks reasonable. Thanks @QuentinRoy for resolving this longstanding blocker and reviving astro-asciidoc 👏🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for astro v5 and remove support for astro < v5 (incompatible with @astrojs/mdx which is needed for the jsx renderer).
It might be possible to retain support for older astro version by implementing our own jsx renderer or move to another approach, but it didn't see worth it.