Skip to content

feat: support astro v5 #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shishkin merged 2 commits into from
Dec 14, 2025
Merged

feat: support astro v5 #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b13e625
fix(deps): update dependency astro to v5
renovate[bot] Dec 2, 2025
f2c97b3
feat: support for astro v5
QuentinRoy Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/astro-asciidoc/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,13 @@
"@asciidoctor/core": "3.0.4"
},
"devDependencies": {
"astro": "4.16.19",
"astro": "5.16.3",
"typescript": "5.9.3",
"unbuild": "3.6.1"
},
"peerDependencies": {
"astro": "^2.8.0 || ^3.0.0 || ^4.0.0",
"@astrojs/mdx": "^4.0.0",
"astro": "^5.0.0",
"vite": "^4.3.9 || ^5.0.0 || ^6.0.0 || ^7.0.0"
}
}
4 changes: 1 addition & 3 deletions packages/astro-asciidoc/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import type { ProcessorOptions } from "@asciidoctor/core";
import type { AstroIntegration } from "astro";
import astroJsx from "astro/jsx/renderer.js";
import type { ViteDevServer } from "vite";
import AsciidocConverter from "./asciidoctor.js";
import type { InitOptions } from "./worker.js";
Expand Down Expand Up @@ -45,7 +44,7 @@ export default function asciidoc(opts?: Options): AstroIntegration {
const { addPageExtension, addRenderer, updateConfig, addWatchFile } =
params as InternalHookParams;

addRenderer(astroJsx);
addRenderer({ name: "astro:mdx", serverEntrypoint: "@astrojs/mdx/server.js" });
Copy link
Owner

@shishkin shishkin Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Is that really it?! I've tested it briefly and it seems to work. Let me just dig into mdx renderer internals to see if my hacky code below still makes sense with it.

addPageExtension(asciidocFileExt);

updateConfig({
Expand All @@ -54,7 +53,6 @@ export default function asciidoc(opts?: Options): AstroIntegration {
{
name: "vite-plugin-astro-asciidoc",
configureServer(s) {
// @ts-expect-error type conflict in dependencies
server = s as ViteDevServer;
},
async transform(_code, id) {
Expand Down
3 changes: 2 additions & 1 deletion packages/example/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
"typescript": "5.9.3"
},
"dependencies": {
"astro": "4.16.19",
"@astrojs/mdx": "^4.3.12",
"astro": "5.16.3",
"astro-asciidoc": "workspace:*"
}
}
Loading