Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: paypal refund modal #185

Closed
wants to merge 1 commit into from
Closed

fix: paypal refund modal #185

wants to merge 1 commit into from

Conversation

Bird87ZA
Copy link
Contributor

@Bird87ZA Bird87ZA commented Apr 1, 2025

The paypal refund modal was not showing text fields as it should.

Before:
image

After:
image

@Bird87ZA Bird87ZA requested review from mstegmeyer and cyl3x April 1, 2025 13:04
@Bird87ZA Bird87ZA self-assigned this Apr 1, 2025
@@ -10,6 +10,6 @@ const { Component } = Shopware;
* @component-example
* <swag-paypal-text-field label="Name" placeholder="placeholder goes here..."></swag-paypal-text-field>
*/
Component.extend('swag-paypal-text-field', 'sw-text-field', {
Component.extend('swag-paypal-text-field', 'sw-text-field-deprecated', {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, the deprecated field is not available in the minimum version 6.6.0.0. At the time of registering the component, we do not even know which Shopware version it is based on.
I guess it's our fault building on a private component, and we should consider building our own instead. Will not work with 6.7 anyway :panic:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the time of the build, in July 2020, this was not private, there is just no notification for these things 🙄
The only reason to use that own component was to set the maxLength property of the input. Can we maybe just add a helpText to the input field for the maximum length and just remove the usage, if this is not possible with sw-text-field?

@cyl3x cyl3x mentioned this pull request Apr 3, 2025
@mstegmeyer mstegmeyer closed this Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants