Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: paypal refund modal #185

Closed
wants to merge 1 commit into from
Closed

fix: paypal refund modal #185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...p/administration/src/module/swag-paypal-payment/component/swag-paypal-text-field/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@ const { Component } = Shopware;
* @component-example
* <swag-paypal-text-field label="Name" placeholder="placeholder goes here..."></swag-paypal-text-field>
*/
Component.extend('swag-paypal-text-field', 'sw-text-field', {
Component.extend('swag-paypal-text-field', 'sw-text-field-deprecated', {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, the deprecated field is not available in the minimum version 6.6.0.0. At the time of registering the component, we do not even know which Shopware version it is based on.
I guess it's our fault building on a private component, and we should consider building our own instead. Will not work with 6.7 anyway :panic:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the time of the build, in July 2020, this was not private, there is just no notification for these things 🙄
The only reason to use that own component was to set the maxLength property of the input. Can we maybe just add a helpText to the input field for the maximum length and just remove the usage, if this is not possible with sw-text-field?

template,
});