SG-39414 Add type annotations #422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-lang
reviewed
Oct 28, 2025
| """ | ||
|
|
||
| import datetime | ||
| from typing import Any |
Contributor
There was a problem hiding this comment.
I don't like using things from outside without having a package/module name.
Suggested change
| from typing import Any | |
| import typing |
Then use typing.Any.
If you are looking for a short version, we can always aggree on
import typing as tp
Contributor
Author
There was a problem hiding this comment.
This is a subjective personal preference, and we cannot enforce this. I agree on being explicit and importing the objects specifically.
Contributor
There was a problem hiding this comment.
we cannot enforce this.
True but the first use usually defines the rule. So this is why I'd like the first iteration to mark our preferences.
eduardoChaucaGallegos
approved these changes
Nov 6, 2025
|
yay! Thanks for taking this to completion! This was on my list after pyside6 stubs and rez. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #393
Thanks @chadrik