Skip to content

Add CI job for macos#1978

Merged
rukai merged 6 commits intoshotover:mainfrom
rukai:macos_ci
Mar 5, 2026
Merged

Add CI job for macos#1978
rukai merged 6 commits intoshotover:mainfrom
rukai:macos_ci

Conversation

@rukai
Copy link
Copy Markdown
Contributor

@rukai rukai commented Feb 26, 2026

Adds a basic CI job for macos.
This ensures that shotover and its tests continues to build on macos without any clippy warnings, but does not make any guarantees if the tests pass or not. (because many tests do not pass on macos)

Logic is mostly copied from the build.yaml job for linux.

Additionally all cpp tests are skipped because getting c++ driver tests compiling on macos is too much trouble.

@rukai rukai marked this pull request as draft February 26, 2026 04:17
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Feb 26, 2026

Merging this PR will not alter performance

✅ 36 untouched benchmarks
⏩ 2 skipped benchmarks1


Comparing rukai:macos_ci (6c605c1) with main (37cdad6)2

Open in CodSpeed

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (34a310d) during the generation of this report, so 37cdad6 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@rukai rukai force-pushed the macos_ci branch 4 times, most recently from 00ccec0 to 9dfe3af Compare March 2, 2026 22:16
@rukai rukai marked this pull request as ready for review March 3, 2026 00:14
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a dedicated GitHub Actions workflow to build/clippy the Rust workspace on macOS, aiming to keep macOS builds warning-free while explicitly excluding the C++ driver feature combinations.

Changes:

  • Introduces a new build_macos.yaml workflow triggered on pushes/PRs to main.
  • Runs cargo clippy and cargo hack --feature-powerset ... clippy on macos-latest.
  • Excludes C++ driver test features from the macOS feature-powerset clippy run.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

rukai and others added 2 commits March 4, 2026 09:48
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@rukai rukai enabled auto-merge (squash) March 4, 2026 22:57
@rukai rukai merged commit 3f0ffea into shotover:main Mar 5, 2026
133 of 139 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants