-
Notifications
You must be signed in to change notification settings - Fork 26
Add CI job for macos #1978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add CI job for macos #1978
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
601377a
Add CI job for macos
rukai 378ccec
Merge branch 'main' into macos_ci
rukai 49d539b
Update .github/workflows/build_macos.yaml
rukai 85b4620
Update .github/workflows/build_macos.yaml
rukai 181a9c2
Merge branch 'main' into macos_ci
rukai 6c605c1
Merge branch 'main' into macos_ci
rukai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| name: Build | ||
|
|
||
| on: | ||
| push: | ||
| branches: [ main ] | ||
| pull_request: | ||
| branches: [ main ] | ||
|
|
||
| # Cancel already running jobs | ||
| concurrency: | ||
| group: build_macos_${{ github.head_ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| env: | ||
| CARGO_TERM_COLOR: always | ||
| RUST_BACKTRACE: 1 | ||
|
|
||
| jobs: | ||
| build: | ||
| name: macos - build | ||
| runs-on: macos-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| # We purposefully dont cache here as build_and_test will always be the bottleneck | ||
| # so we should leave the cache alone so build_and_test can make more use of it. | ||
| - name: Install cargo-hack | ||
| uses: taiki-e/install-action@v2 | ||
| with: | ||
| tool: cargo-hack@0.6.16 | ||
| - name: Install deps | ||
| run: brew install gcc | ||
| - name: Ensure that dev tools compiles and has no warnings with no features enabled | ||
| run: cargo clippy --locked ${{ matrix.cargo_flags }} --all-targets -- -D warnings | ||
| - name: Ensure that shotover-proxy compiles and has no warnings under every possible combination of features | ||
| # some things to explicitly point out: | ||
| # * clippy also reports rustc warnings and errors | ||
| # * clippy --all-targets is not run so we only build the shotover_proxy executable without the tests/benches | ||
| run: cargo hack --feature-powerset --at-least-one-of valkey,cassandra,kafka,opensearch --exclude-features kafka-cpp-driver-tests,cassandra-cpp-driver-tests clippy --locked ${{ matrix.cargo_flags }} --package shotover-proxy -- -D warnings | ||
rukai marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.