fix: Modify text colors for dark mode readability

[ApocDev]

This pull request improves the text contrast for highlighted rows in dark mode.

It also simplifies the color scheme setup by not using a magic array.

Before:

[shpaass]

To facilitate the review, could you please post the before-after comparison?

[ApocDev]

To facilitate the review, could you please post the before-after comparison?

Added the before picture. (Note: the checkboxes are a separate PR I'll be adding shortly, so ignore them for now)

[Dorus]

This was already broken before, but possibly you could sweep this up too: The yellow exclamation marker is also quite dark and unreadable in dark mode:

possibly make it lighter?

[DaleStan]

I thought the use of different foreground colors was intentional (@veger, @shihan42 ?), but I'm not opposed to consolidating them.

[ApocDev]

I thought the use of different foreground colors was intentional (@veger, @shihan42 ?), but I'm not opposed to consolidating them.

It may have been intentional, but it's also incredibly difficult to read. Reading the blue is nearly impossible in some cases.

Typically, text vs background should have a contrast ratio of at least 4.5:1. The blue alone is only 1.77:1.

That said, in a lot of dark-mode schemes, text is just various shades of gray, and you utilize the background color for more "broad" information, especially when it's "just" text, and not things like headers, buttons, etc.

[Dorus]

I did like the old foreground color, but contrast is more important to me than the nice look, so i like the new option more. We can always go back to different foreground colors with better contrast later.

I've updated this to split out icon colors entirely, and modified it slightly.

Yeah nice, my numbers where just a suggestion, my feel for colors is terrible overall :)

[veger]

I thought the use of different foreground colors was intentional

There is some maths going on with the colors, that is why they are always in 'pairs' of 4. For example:

yafc-ce/Yafc.UI/ImGui/ImGuiUtils.cs

Line 121 in 26a7a00

using (gui.EnterGroup(padding ?? DefaultButtonPadding, active ? color + 2 : color + 3)) {

(But there are more places)

So simply changing the meaning of the 4 colors might have some side effects, if we are not careful and check all scenarios.

I cannot remember the exact reasoning behind them anymore, too long ago... 😄

[shihan42]

Looks like a good idea. I must confess I didn't really care for the dark mode colors back when I did the row highlighting.
So go for it, make it look better!

And yes, the strange color array thingamabob should really be refactored. I was to give it a try, but then RL happened. Feel free to give it a make over.

[ApocDev]

Looks like a good idea. I must confess I didn't really care for the dark mode colors back when I did the row highlighting. So go for it, make it look better!

And yes, the strange color array thingamabob should really be refactored. I was to give it a try, but then RL happened. Feel free to give it a make over.

I'll look into this as a separate PR. It might be part of some changes to the input system that I'm working on. (The current one is... "ok" at best)

[shpaass]

Squashed the changelog commit into the first commit.
Moved the reminder in changelog below the general introduction.
Reworded the commit subjects so they fit the Github 70-character limit.
Squashed two last commits together because the latter fixes the former, from what I understand.