Pinnable "Page Search" with Right click #528

kubiix · 2025-09-23T21:28:32Z

This pull request introduces a new "pinned" mode for the pages list dropdown in the UI, allowing users to keep the list open for easier navigation. It refactors dropdown management to support multiple dropdown types, adds conditional tooltip behavior, and ensures the pages list stays up-to-date with project changes like renaming or adding pages. The changes also improve user interaction by enabling right-click to pin the dropdown and updating localization to inform users of this feature.

UI/UX Improvements:

Added a "pinned" mode for the pages list dropdown, allowing users to keep it open via right-click; this state is stored in ProjectSettings.isPagesListPinned and reflected in the UI.
Refactored dropdown management to support separate dropdowns for general use and for the pages list, including logic to close pinned dropdowns and keep the UI state consistent.

Dropdown and Tooltip Logic:

Added WithTooltipConditional to show tooltips only when dropdown is not pinned, improving clarity for users.
Introduced new methods and properties for managing the pinned state and source matching for dropdown panels, including updates to DropDownPanel and SimpleDropDown.

Project List Synchronization:

Centralized and improved updating of the pages list in dropdowns to ensure changes (add, remove, rename) are immediately reflected in the UI, including after page edits and additions.

Localization Update:

Updated the localization string for the pages list/search button to inform users about the new right-click-to-pin feature.

Minor Fixes and Refactoring:

Various minor refactors to method signatures, property names, and event handling to support the new features and improve code clarity.

veger

Thank you. Most look good to me.

I am currently not able to check the actual behavior. So either someone else has to check, or I can do tomorrow.

veger · 2025-09-23T21:53:03Z

Yafc.UI/Core/Window.cs

+    protected DropDownPanel? commonDropDown;
    private SimpleDropDown? simpleDropDown;
+    protected DropDownPanel? pagesDropDown;
+    private SimpleDropDown? pagesSimpleDropDown;


It is not clear to me (by names) what all of these dropdown are (doing).
I know it wasn't very clear before, but since we are touching this, it might be nice to clarify this a little

I haven't checked too much DropDownPanel x SimpleDropDown

I just needed to use separate dropdown for pages search to be able to open for example the dropdown for recipe column and keep the pages search opened - until now just one dropdown could be opened at the same time while reusing the single one shared DropDownPanel and SimpleDropDown

Whatever's going on with commonDropDown vs simpleDropDown is quite tortured. I'd love to see that refactored, but it seems like a lot of work.

I would like to see the two new fields renamed to better explain why we need two fields for one dropdown.

veger · 2025-09-23T21:55:56Z

Yafc.UI/Core/Window.cs

+        Rebuild();
+    }
+
+    public bool ClosePagesListDropDown(ImGui targetGui, Rect target) {


Function documentation would be appreciated for (new) functions. In this case even more, as it is unclear what the returned bool is suppose to represent.

(Later I figured, it seems to be true when the dropdown was not closed?)

veger · 2025-09-23T21:56:49Z

Yafc.UI/Core/Window.cs

+        this.
+        Rebuild();


Suggested change

this.

Rebuild();

this.Rebuild();

No idea if you meant to explicitly wanted/needed to include this, if not please just call Rebuild() instead

veger · 2025-09-23T21:58:56Z

Yafc.UI/ImGui/ImGuiUtils.cs


        return evt;
    }
+    public static bool WithTooltipConditional(this ButtonEvent evt, bool condition, ImGui gui, string tooltip, Rect? rect = null) {


@shpaass Same as in #529 I guess, we need to make sure we are not duplicating this function when merged both PRs

veger · 2025-09-23T21:59:46Z

changelog.txt

 Version:
 Date:
+    Features:
+        - Add Right-click option to show the Page Search dropdown pinned to keep it open.


You read my mind 😉

DaleStan

Several files in 315170d also got committed with mixed line endings. Again, I can fix that if you'd like.

The other thing I noticed is that the page tooltip isn't drawn when the search dorpdown is pinned. That's not necessarily wrong, but I expected to see a comment explaining why that happened.

DaleStan · 2025-09-24T02:32:34Z

Yafc.Model/Model/Project.cs

    public float PollutionCostModifier { get; set; } = 0;
-    public float spoilingRate { get; set; } = 1;
+    public float spoilingRate { get; set; } = 1;
+    public bool isPagesListPinned { get; set; }


This should go in ProjectPreferences instead. I haven't added a comment about this yet, but Preferences is for things that don't require the solver to run again, and Settings is for things that do.

Thank you for catching that.

Preferences is for things that don't require the solver to run again, and Settings is for things that do.

This info should go to the javadoc. I'll make a ticket for that just to not forget.

DaleStan · 2025-09-24T03:30:57Z

Yafc/Windows/MainScreen.cs

+                    if (!ClosePagesListDropDown(gui, gui.lastRect)) {
+                        showPagesListDropDown(pin);
+                        this.project.settings.isPagesListPinned = pin;
+
+                    }
+                    else {
+                        this.project.settings.isPagesListPinned = false;
+                    }


As a follow-up to veger's comment about ClosePagesListDropDown, I think this would be better as

Suggested change

if (!ClosePagesListDropDown(gui, gui.lastRect)) {

showPagesListDropDown(pin);

this.project.settings.isPagesListPinned = pin;

}

else {

this.project.settings.isPagesListPinned = false;

}

bool isDropdownOpen = /*something*/;

if (isDropdownOpen) {

ClosePagesListDropDown(gui);

project.settings.isPagesListPinned = false;

}

else {

showPagesListDropDown(pin);

project.settings.isPagesListPinned = pin;

}

DaleStan · 2025-09-24T04:33:11Z

Yafc.UI/Core/Window.cs

+    protected DropDownPanel? commonDropDown;
    private SimpleDropDown? simpleDropDown;
+    protected DropDownPanel? pagesDropDown;
+    private SimpleDropDown? pagesSimpleDropDown;


Whatever's going on with commonDropDown vs simpleDropDown is quite tortured. I'd love to see that refactored, but it seems like a lot of work.

I would like to see the two new fields renamed to better explain why we need two fields for one dropdown.

shpaass · 2025-09-24T10:52:19Z

I'd like to discuss if this feature is redundant. Do you really search the list of pages that often that you need it pinned? Is the usual list on top of the page not enough?

veger · 2025-09-24T19:57:21Z

I totally forgot that this search is even there (I usually use regular search on the Summary page).

But when I tried the search feature, I noticed how annoying it is that is closes each time when clicking a result going to the page it belong to. With this is it much faster clicking the results in order to find what you intended to find.

DaleStan · 2025-09-25T04:09:00Z

Do you really search the list of pages that often that you need it pinned? Is the usual list on top of the page not enough?

To me, the vertical tab list is the primary benefit, and always showing the search controls is incidental.

On the other hand, if the vertical list is the primary benefit, there should be a program preference that lets the user move MainScreenTabBar to any of the four sides of the window, rather than a way to open the search in a way that it doesn't auto-close. Now that I'm thinking about this, I'm surprised I haven't seen a request to have the tabs listed on the left instead of the top.

Pinnable "Page Search" with Right click

315170d

kubiix requested a review from shpaass as a code owner September 23, 2025 21:28

Pinnable "Page Search" with Right click (changelog)

24d5960

veger reviewed Sep 23, 2025

View reviewed changes

DaleStan requested changes Sep 24, 2025

View reviewed changes

shpaass mentioned this pull request Sep 24, 2025

[Docs] Document the distinction between Preferences and Settings #532

Open

shpaass mentioned this pull request Sep 24, 2025

Proposal: Remove the split-screen "Open as secondary" (Ctrl+Click on the page) #533

Open

Pinnable "Page Search" with Right click #528

Are you sure you want to change the base?

Pinnable "Page Search" with Right click #528

Uh oh!

Conversation

kubiix commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

veger left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DaleStan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shpaass commented Sep 24, 2025

Uh oh!

veger commented Sep 24, 2025

Uh oh!

DaleStan commented Sep 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kubiix commented Sep 23, 2025 •

edited

Loading