Skip to content

Conversation

@DaleStan
Copy link
Collaborator

@DaleStan DaleStan commented Oct 7, 2025

I set out to fix #535, but then I couldn't load several of my test projects, (primarily https://mods.factorio.com/mod/kry-all-planet-mods) so I fixed those too.

There's still several warnings and accessibility issues, but projects using Pacifist, PlanetsLib, Muluna, and/or Cerys (and possibly others) can at least load.

@DaleStan DaleStan requested a review from veger October 7, 2025 17:05
@DaleStan DaleStan requested a review from shpaass as a code owner October 7, 2025 17:05
@shpaass
Copy link
Owner

shpaass commented Oct 7, 2025

Gaddam, nice stuff! Will take a while to review, but nice.

Copy link
Collaborator

@veger veger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Casually drops a tokenizer, syntax tree parser and math evaluator to fix a mod...
Nice! 😄

It all looks good to me, I just have one question/discussion related to the version comparison. Although I don't know a better way myself...

Copy link
Owner

@shpaass shpaass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your efforts!

@shpaass shpaass merged commit f4ae4f2 into shpaass:master Oct 15, 2025
1 check passed
@DaleStan DaleStan deleted the fix-load-errors branch October 17, 2025 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pacifist mod load error

3 participants