Support all technology triggers #549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shpaass
reviewed
Oct 28, 2025
shpaass
reviewed
Oct 28, 2025
DaleStan
commented
Oct 28, 2025
DaleStan
force-pushed
the
fix-load-warnings
branch
from
c0f81e4 to
f551956
Compare
|
I have to ask it just in case because of the model changes: Have you tested that it's backward-compatible? In other words, can the saves from the previous version be loaded? |
|
Yes, this works with both a Factorio 1.1 project and a Yafc 2.13 project. |
veger
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the load warnings (for the "craft-fluid" and "scripted"
TechnologyTriggers) on the all-planets torture test. It does not fix the accessibility issues; I'm still pondering how Lignumis can be handled.It also adds the missing quality restrictions for "craft-item" and "build-entity".
The display of the only scripted technology would be more interesting if we displayed tags, but that's out of scope for this PR.
The text before the tags are stripped: