Skip to content

feat: Add lefthook support#662

Merged
talos-bot merged 1 commit into
siderolabs:mainfrom
majabojarska:feat/lefthook
Jun 2, 2026
Merged

feat: Add lefthook support#662
talos-bot merged 1 commit into
siderolabs:mainfrom
majabojarska:feat/lefthook

Conversation

@majabojarska

@majabojarska majabojarska commented May 28, 2026

Copy link
Copy Markdown
Member

Add support for lefthook.

Executes generate, fmt, lint-fmt, lint, generate and conformance make targets on commit (at different stages). Whether they're included, depends on the project kres is generating the configs for.

This is completely opt-in for the end user (or rather developer). Install the hooks locally via lefthook install (requires lefthook to be installed)

@majabojarska majabojarska self-assigned this May 28, 2026
@majabojarska majabojarska marked this pull request as ready for review May 28, 2026 15:05
@github-project-automation github-project-automation Bot moved this to To Do in Planning May 28, 2026
@talos-bot talos-bot moved this from To Do to In Review in Planning May 28, 2026
@majabojarska majabojarska requested a review from Copilot May 28, 2026 15:25

This comment was marked as outdated.

This comment was marked as resolved.

Comment thread internal/project/golang/gofumpt.go

This comment was marked as resolved.

@majabojarska majabojarska linked an issue May 28, 2026 that may be closed by this pull request
Comment thread internal/project/common/repository.go Outdated
Comment thread internal/project/common/repository.go Outdated
@majabojarska majabojarska marked this pull request as draft May 29, 2026 11:48
@majabojarska

This comment was marked as resolved.

@majabojarska majabojarska force-pushed the feat/lefthook branch 5 times, most recently from 2076b09 to 825a7e4 Compare June 1, 2026 09:12
@majabojarska majabojarska marked this pull request as ready for review June 1, 2026 09:15
Comment thread internal/project/custom/custom_test.go Outdated
Comment thread internal/project/common/repository.go
Comment thread internal/output/lefthook/lefthook.go Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 32 out of 32 changed files in this pull request and generated 3 comments.

Comment thread internal/output/lefthook/config.go
Comment thread internal/output/lefthook/config.go
Comment thread internal/output/preamble.go Outdated
Add support for lefthook.
Executes fmt, generate, lint, and conformance make targets on commit (at
different stages).

Signed-off-by: Maja Bojarska <maja.bojarska@siderolabs.com>
@github-project-automation github-project-automation Bot moved this from In Review to Approved in Planning Jun 2, 2026
@majabojarska

Copy link
Copy Markdown
Member Author

/m

@talos-bot talos-bot merged commit c1cf61e into siderolabs:main Jun 2, 2026
15 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Done in Planning Jun 2, 2026
@majabojarska majabojarska deleted the feat/lefthook branch June 2, 2026 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Add support for pre-commit (or equivalent)

6 participants