chore: rekres#2921
Conversation
Adds lefthook.yml Signed-off-by: Maja Bojarska <maja.bojarska@siderolabs.com>
utkuozdemir
left a comment
utkuozdemir
left a comment
There was a problem hiding this comment.
I was doing this + dep bumps atm as part of my Omni eng duty, but no harm :)
| instance_id?: string | ||
| provider_id?: string | ||
| spot?: boolean | ||
| tags?: {[key: string]: string} |
There was a problem hiding this comment.
This is a generated file, should be result of make generate-frontend no?
There was a problem hiding this comment.
This was in fact a result of make generate-frontend
There was a problem hiding this comment.
I'm worried that ci check-dirty did not catch this
There was a problem hiding this comment.
Just confirmed this diff also appears when running make generate-frontend on main. Seems like this was stale/out of sync?
There was a problem hiding this comment.
I'm worried that ci check-dirty did not catch this
It seems it is because check-dirty only does make generate. Doesn't do generate-frontend - it's an Omni thing.
We could change kres to also to generate-frontend when frontend is detected (no big deal though).
There was a problem hiding this comment.
Just confirmed this diff also appears when running
make generate-frontendonmain. Seems like this was stale/out of sync?
Yes, it sometimes happens, we forget to run make generate && make generate-frontend for a while.
(check-dirty thing is relatively new I think, and it only covers generate)
There was a problem hiding this comment.
Confirming check-dirty doesn't depend on generate-frontend, so that's why it didn't catch this (src). I'll be implementing that dependency into Kres, and then we'll rekres in a separate PR.
|
Also, need to rebase. I recommend the moment you see What I do: I do |
|
Closing, superseded by #2922 |
4 participants
Follow-up to siderolabs/kres#662
Updates Makefile, creates lefthook.yml