fix: generate also depends on generate-* targets#665
Merged
talos-bot merged 1 commit intoJun 2, 2026
Conversation
majabojarska
force-pushed
the
fix/check-dirty-deps-on-gen-front
branch
from
d7b364a to
5683765
Compare
This also fixes a blindspot in the check-dirty target, which would miss stale artifacts if they were generated by additional "generate-*" targets. Signed-off-by: Maja Bojarska <maja.bojarska@siderolabs.com>
majabojarska
force-pushed
the
fix/check-dirty-deps-on-gen-front
branch
from
5683765 to
d3457c9
Compare
majabojarska
changed the title
generate also depends on generate-* targets
smira
approved these changes
Jun 2, 2026
frezbo
approved these changes
Jun 2, 2026
Member
Author
|
/m |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #664
generatedidn't depend on the additionalgenerate-*targets, which made it incomplete for some repositories (e.g. Omni). Sincecheck-dirtyuses thegeneratetarget to check for stale artifacts, this lead to stalegenerate-frontendoutputs in Omni, ascheck-dirtydidn't catch it (link).generate-*targets.