Skip to content

chore: rekres #2921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
majabojarska wants to merge 1 commit into from
Closed

chore: rekres #2921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# THIS FILE WAS AUTOMATICALLY GENERATED BY KRES, PLEASE DO NOT EDIT.
#
# Generated on 2026-05-29T11:29:48Z by kres 8085f7d.
# Generated on 2026-06-02T09:34:03Z by kres c1cf61e.

# common variables

Expand Down Expand Up @@ -255,7 +255,7 @@ lint-gofumpt-client: ## Runs gofumpt linter.

.PHONY: fmt
fmt: ## Formats the source code
@docker run --rm -it -v $(PWD):/src -w /src golang:$(GO_VERSION) \
@docker run --rm -v $(PWD):/src -w /src golang:$(GO_VERSION) \
bash -c "export GOTOOLCHAIN=local; \
export GO111MODULE=on; export GOPROXY=https://proxy.golang.org; \
go install mvdan.cc/gofumpt@$(GOFUMPT_VERSION) && \
Expand Down Expand Up @@ -522,7 +522,7 @@ release-notes: $(ARTIFACTS)
.PHONY: conformance
conformance:
@docker pull $(CONFORMANCE_IMAGE)
@docker run --rm -it -v $(PWD):/src -w /src $(CONFORMANCE_IMAGE) enforce
@docker run --rm -v $(PWD):/src -w /src $(CONFORMANCE_IMAGE) enforce

.PHONY: renovate-local
renovate-local: ## runs renovate locally to check syntax and test configuration
Expand Down
1 change: 1 addition & 0 deletions frontend/src/api/omni/specs/omni.pb.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,7 @@ export type MachineStatusSpecPlatformMetadata = {
instance_id?: string
provider_id?: string
spot?: boolean
tags?: {[key: string]: string}

@frezbo frezbo Jun 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unintended?

@utkuozdemir utkuozdemir Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a generated file, should be result of make generate-frontend no?

@majabojarska majabojarska Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was in fact a result of make generate-frontend

@frezbo frezbo Jun 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm worried that ci check-dirty did not catch this

@majabojarska majabojarska Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just confirmed this diff also appears when running make generate-frontend on main. Seems like this was stale/out of sync?

@utkuozdemir utkuozdemir Jun 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm worried that ci check-dirty did not catch this

It seems it is because check-dirty only does make generate. Doesn't do generate-frontend - it's an Omni thing.

We could change kres to also to generate-frontend when frontend is detected (no big deal though).

@utkuozdemir utkuozdemir Jun 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just confirmed this diff also appears when running make generate-frontend on main. Seems like this was stale/out of sync?

Yes, it sometimes happens, we forget to run make generate && make generate-frontend for a while.

(check-dirty thing is relatively new I think, and it only covers generate)

@majabojarska majabojarska Jun 2, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming check-dirty doesn't depend on generate-frontend, so that's why it didn't catch this (src). I'll be implementing that dependency into Kres, and then we'll rekres in a separate PR.

}

export type MachineStatusSpecSchematicInitialState = {
Expand Down
36 changes: 36 additions & 0 deletions lefthook.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
# THIS FILE WAS AUTOMATICALLY GENERATED BY KRES, PLEASE DO NOT EDIT.
#
# Generated on 2026-06-02T09:34:03Z by kres c1cf61e.

commit-msg:
parallel: false
commands:
conformance:
run: make conformance
pre-commit:
jobs:
- name: fix
group:
parallel: false
jobs:
- name: generate frontend
run: make generate-frontend
stage_fixed: true
- name: generate
run: make generate
stage_fixed: true
- name: fmt
run: make fmt
stage_fixed: true
- name: fmt
run: make fmt
stage_fixed: true
- name: lint-fmt
run: make lint-fmt
stage_fixed: true
- name: lint
group:
parallel: false
jobs:
- name: lint
run: make lint
Loading