Skip to content

refactor(split): migrate to Angular output function #2275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spliffone wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(split): migrate to Angular output function #2275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions api-goldens/element-ng/split/index.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

import { AfterContentInit } from '@angular/core';
import * as _angular_core from '@angular/core';
import { EventEmitter } from '@angular/core';
import { OnChanges } from '@angular/core';
import { QueryList } from '@angular/core';
import { Signal } from '@angular/core';
Expand Down Expand Up @@ -48,7 +47,7 @@ export class SiSplitComponent implements AfterContentInit, OnChanges {
// (undocumented)
sizes: number[];
// (undocumented)
readonly sizesChange: EventEmitter<number[]>;
readonly sizesChange: _angular_core.OutputEmitterRef<number[]>;
stateId?: string;
}

Expand All @@ -61,7 +60,7 @@ export class SiSplitPartComponent implements OnChanges {
// (undocumented)
actions: Action[];
// (undocumented)
readonly collapseChanged: EventEmitter<boolean>;
readonly collapseChanged: _angular_core.OutputEmitterRef<boolean>;
get collapsed(): boolean;
// (undocumented)
collapseDirection: CollapseTo;
Expand Down Expand Up @@ -98,7 +97,7 @@ export class SiSplitPartComponent implements OnChanges {
showHeader: boolean;
size?: number;
// (undocumented)
readonly stateChange: EventEmitter<PartState>;
readonly stateChange: _angular_core.OutputEmitterRef<PartState>;
stateId?: string;
toggleCollapse(): void;
}
Expand Down
8 changes: 3 additions & 5 deletions projects/element-ng/split/si-split-part.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,18 @@
* Copyright (c) Siemens 2016 - 2026
* SPDX-License-Identifier: MIT
*/
/* eslint-disable @angular-eslint/prefer-output-emitter-ref */
import { NgTemplateOutlet } from '@angular/common';
import {
booleanAttribute,
ChangeDetectionStrategy,
Component,
computed,
ElementRef,
EventEmitter,
inject,
Input,
numberAttribute,
OnChanges,
Output,
output,
signal,
SimpleChanges,
TemplateRef
Expand Down Expand Up @@ -133,8 +131,8 @@ export class SiSplitPartComponent implements OnChanges {
*/
@Input({ transform: booleanAttribute }) collapseOthers = false;

@Output() readonly collapseChanged = new EventEmitter<boolean>();
@Output() readonly stateChange = new EventEmitter<PartState>();
readonly collapseChanged = output<boolean>();
readonly stateChange = output<PartState>();

/** @internal */
index = 0;
Expand Down
8 changes: 3 additions & 5 deletions projects/element-ng/split/si-split.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
* Copyright (c) Siemens 2016 - 2026
* SPDX-License-Identifier: MIT
*/
/* eslint-disable @angular-eslint/prefer-output-emitter-ref */
import {
AfterContentInit,
ChangeDetectionStrategy,
Expand All @@ -11,17 +10,16 @@ import {
computed,
ContentChildren,
ElementRef,
EventEmitter,
inject,
Input,
NgZone,
OnChanges,
Output,
QueryList,
signal,
Signal,
SimpleChanges,
DOCUMENT
DOCUMENT,
output
} from '@angular/core';
import {
isRTL,
Expand Down Expand Up @@ -83,7 +81,7 @@ export class SiSplitComponent implements AfterContentInit, OnChanges {
*/
@Input() stateId?: string;

@Output() readonly sizesChange = new EventEmitter<number[]>();
readonly sizesChange = output<number[]>();

@WebComponentContentChildren(SiSplitPartComponent)
@ContentChildren(SiSplitPartComponent)
Expand Down
Loading