build(eslint): enable rule @typescript-eslint/prefer-readonly#2296
build(eslint): enable rule @typescript-eslint/prefer-readonly#2296spliffone wants to merge 1 commit into
@typescript-eslint/prefer-readonly#2296Conversation
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
spliffone
force-pushed
the
build/eslint-private-readonly-rule
branch
from
bc0550f to
5ec61b3
Compare
|
IMO this adds little value. I.e. if a private member is readonly or not is such a minor detail that it does not justify all the churn created. Traceability of changes is more important. But maybe that's just me. |
| * The focus on close is only relevant when the directive is configured without a calendar button. | ||
| */ | ||
| private overlaySubscriptions?: Subscription[]; | ||
| private readonly overlaySubscriptions?: Subscription[]; |
There was a problem hiding this comment.
that's just complete non-sense. This is undefined and then can never be set. Begs the question if this is unused and can be removed instead
There was a problem hiding this comment.
You are right I dropped it.
spliffone
force-pushed
the
build/eslint-private-readonly-rule
branch
from
5ec61b3 to
651a3f0
Compare
|
@dr-itz this came up, as I was annoyed always having review feedback to have injected things as readonly. But still, for public stuff contributing a dedicated rule to anguar-eslint might be more usefull |
spliffone
force-pushed
the
build/eslint-private-readonly-rule
branch
from
651a3f0 to
33e7617
Compare
3 participants
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: