fix(core/category-filter): adjust padding if no icon is shown#2033
Conversation
🦋 Changeset detectedLatest commit: fff385b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
nuke-ellington
left a comment
nuke-ellington
left a comment
There was a problem hiding this comment.
Why did all the snapshots change? The padding should be the same?
nuke-ellington
changed the title
nuke-ellington
left a comment
nuke-ellington
left a comment
There was a problem hiding this comment.
It is still unclear why the screenshots changed for the filter with icon?
Current implementation Figma Design (here it is mentioned that the component height needs to be 32 pixels and the text is also a bit thinner) 
With my fix (which is in PR rn), the text is using the intended style, as well as the component height is restored to 32 pixels I think the hardcoded implementation from earlier (using !important) was causing this error. |
nuke-ellington
left a comment
nuke-ellington
left a comment
There was a problem hiding this comment.
We should a no-icon version to the basic VRT snaphot.
|
|
danielleroux
dismissed
nuke-ellington’s stale review
Reviewed latest changes 👍
4 participants
💡 What is the current behavior?
There is a space appearing when hide-icon property is set to true.
GitHub Issue Number: #
JIRA issue- IX-2082
🆕 What is the new behavior?
Said space is removed now an replace with a tiny-space
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm test)pnpm lint)pnpm build, changes pushed)👨💻 Help & support