Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
e9f07a4
Added fix for the tinyspace not appearing
1307-Dev Jul 28, 2025
01a09e4
Added lint fix
1307-Dev Jul 28, 2025
2abfe7f
Added css changes to category filter and input element
1307-Dev Jul 30, 2025
49a4324
Removed comments
1307-Dev Jul 30, 2025
a0e91f8
Consolidated the variables.
1307-Dev Jul 30, 2025
1d8caad
Merge branch 'main' into ix-2082-category-filter
1307-Dev Jul 30, 2025
83e5607
Added fix for readonly state and updated VRTs
1307-Dev Jul 30, 2025
a04c70a
Fixing conflicts
1307-Dev Jul 31, 2025
fa11089
Merge branch 'main' into ix-2082-category-filter
1307-Dev Jul 31, 2025
360e491
Create happy-suns-report.md
nuke-ellington Jul 31, 2025
940f73d
Added changes
1307-Dev Aug 4, 2025
79dbb95
Merge branch 'main' into ix-2082-category-filter
1307-Dev Aug 4, 2025
a07e811
updated VRT for category filter
Aug 5, 2025
3902f3a
Merge branch 'main' into ix-2082-category-filter
1307-Dev Aug 5, 2025
e385380
Resolve conflicts in category filter screenshots
1307-Dev Aug 5, 2025
14af305
Update category filter screenshots
1307-Dev Aug 5, 2025
6e6ff09
Merge branch 'main' into ix-2082-category-filter
1307-Dev Aug 7, 2025
dee6736
Merge branch 'main' into ix-2082-category-filter
1307-Dev Aug 7, 2025
5d0a76b
resolved merge conflicts
1307-Dev Aug 7, 2025
4fa4c8d
Merge branch 'main' into ix-2082-category-filter
1307-Dev Aug 7, 2025
2ce3705
FIxing snapshots conflicts
1307-Dev Sep 3, 2025
31506b9
Merge branch 'main' into ix-2082-category-filter
1307-Dev Sep 3, 2025
0eec0bc
Update visual regression screenshots for category filter
1307-Dev Sep 3, 2025
c495844
Adding new screenshots for basic- no icon variant
1307-Dev Sep 29, 2025
30035e9
Merge branch 'main' into ix-2082-category-filter
1307-Dev Oct 6, 2025
1c4b52a
VRT SS updated
RamVinayMandal Oct 6, 2025
66dd371
Merge branch 'main' into ix-2082-category-filter
1307-Dev Oct 6, 2025
e87edc6
Merge branch 'main' into ix-2082-category-filter
1307-Dev Oct 6, 2025
f85cbcd
Merge remote-tracking branch 'origin/main' into ix-2082-category-filter
danielleroux Nov 7, 2025
fff385b
update snapshots
danielleroux Nov 7, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/happy-suns-report.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@siemens/ix": patch
---

Prevent empty space if no icon is shown in __category-filter__.
4 changes: 2 additions & 2 deletions packages/core/scss/mixins/_input.scss
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@
@use './fonts';
@use './validation/form-component';

@mixin element-input($feature-read-only: true) {
@mixin element-input($feature-read-only: true, $padding: 0.25rem 0.5rem) {
& {
min-height: 2rem;
width: auto;
padding: 0.25rem 0.5rem;
padding: $padding;
background-color: var(--theme-input--background);
color: var(--theme-input--color);
appearance: textfield;
Expand Down
30 changes: 19 additions & 11 deletions packages/core/src/components/category-filter/category-filter.scss
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,25 @@
}

.input-container {
&:not(.readonly):not(.disabled) {
@include input.element-input('false');
$padding-with-icon: 1px vars.$large-space 1px 1.75rem;
$padding-no-icon: 1px vars.$large-space 1px vars.$tiny-space;

&:not(.readonly) {
&:not(.no-icon) {
@include input.element-input(false, $padding-with-icon);
}
&.no-icon {
@include input.element-input(false, $padding-no-icon);
}
}

&.readonly {
&:not(.no-icon) {
@include input.element-input(true, $padding-with-icon);
}
&.no-icon {
@include input.element-input(true, $padding-no-icon);
}
}

&:not(.readonly):not(.disabled):hover {
Expand All @@ -57,18 +74,9 @@
var(--theme-input--border-color-bottom--disabled);
}

&.readonly {
@include input.element-input;
}

display: flex;
height: auto;
max-height: 3.75rem;
padding: 1px vars.$large-space 1px 1.75rem !important;

&.no-icon {
padding-left: vars.$tiny-space;
}
}

.token-container {
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
<!--
SPDX-FileCopyrightText: 2024 Siemens AG

SPDX-License-Identifier: MIT
-->

<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8" />
<meta
name="viewport"
content="width=device-width, initial-scale=1.0, minimum-scale=1.0, maximum-scale=5.0"
/>
<title>Stencil Component Starter</title>
</head>
<body>
<ix-category-filter
placeholder="Filter by.."
hide-icon
></ix-category-filter>
<script type="module">
(async () => {
await window.customElements.whenDefined('ix-category-filter');
const categoryFilter = document.querySelector('ix-category-filter');
categoryFilter.suggestions = [
'Option A',
'Option B',
'Option C',
'Option D',
'Option E',
'Option F',
];
})();
</script>
<script src="./../../utils/test/runtime/main.ts" type="module"></script>
</body>
</html>
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,13 @@ regressionTest.describe('category-filter', () => {
expect(await page.screenshot({ fullPage: true })).toMatchSnapshot();
});

regressionTest('basic-no-icon', async ({ page }) => {
await page.goto('category-filter/basic-no-icon');
await page.locator('input').click();

expect(await page.screenshot({ fullPage: true })).toMatchSnapshot();
});

regressionTest('categories', async ({ page }) => {
await page.goto('category-filter/categories');
await page.locator('input').first().click();
Expand Down
Loading