Code review and minor corrections #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ar decoding failure Reverted the `verifier_challenge` method to its previous implementation because the optimized version failed to produce a valid scalar in some edge cases. The issue arose when attempting to convert a reduced BigUint to a field scalar via its byte representation (`from_repr`), which panicked when the representation was out of bounds or invalid for the underlying field. This ensures compatibility and correctness when deriving challenges from squeezed bytes.
nougzarm
commented
Jul 3, 2025
| .collect(); | ||
| let prover_state = (nonces.clone(), witness.clone()); | ||
| let commitment = self.0.linear_map.evaluate(&nonces)?; | ||
| let prover_state = (nonces, witness.clone()); |
Collaborator
Author
There was a problem hiding this comment.
Computing commitment before prover state saves cloning of the nonces vector
nougzarm
commented
Jul 3, 2025
| Ok(ProtocolCommitment::And(commitments)) | ||
| } | ||
| Protocol::Or(ps) => { | ||
| Protocol::And(ps) | Protocol::Or(ps) => { |
Collaborator
Author
There was a problem hiding this comment.
The calculation is done in the same way in the cases And and Or
nougzarm
commented
Jul 3, 2025
src/errors.rs
Outdated
| /// Indicates a mismatch in parameter sizes during batch verification. | ||
| #[error("Mismatched parameter sizes for batch verification.")] | ||
|
|
||
| /// The sizes of input parameters (e.g., witnesses, commitments) do not match expected values. |
Collaborator
Author
There was a problem hiding this comment.
This error can occur in different contexts (always being due to a size problem)
nougzarm
commented
Jul 3, 2025
| pub struct LinearMap<G: Group> { | ||
| /// The set of linear combination constraints (equations). | ||
| pub constraints: Vec<LinearCombination<G>>, | ||
| // TODO: Update the usage of the word "morphism" |
Collaborator
Author
There was a problem hiding this comment.
The name "morphism" has been changed to "linear map"
nougzarm
commented
Jul 3, 2025
| /// - `simulate_transcript` | ||
| #[allow(clippy::type_complexity)] | ||
| pub trait SigmaProtocolSimulator: SigmaProtocol { | ||
| /// Simulates a protocol transcript given a challenge. |
Collaborator
Author
There was a problem hiding this comment.
This function does not take challenge as an argument
- No need to define type aliases
nougzarm
commented
Jul 3, 2025
| pedersen_commitment_dleq, | ||
| }; | ||
|
|
||
| type Codec = ByteSchnorrCodec<G, KeccakDuplexSponge>; |
Collaborator
Author
There was a problem hiding this comment.
Such an alias is already defined in the codec module
mmaker
approved these changes
Jul 4, 2025
Signed-off-by: Michele Orrù <[email protected]>
Chausseaumoine
pushed a commit
to Chausseaumoine/sigma-rs
that referenced
this pull request
Jul 7, 2025
Co-authored-by: Michele Orrù <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.