feat: no_std support. #79
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds no_std support to the codebase, enabling the library to compile and run in environments without the standard library. The key changes involve replacing standard library dependencies with their core/alloc equivalents and making standard library features optional.
Key Changes
- Added conditional compilation for std vs no_std environments using feature flags
- Replaced standard library imports (Vec, HashMap, String, etc.) with alloc equivalents
- Added no_std-compatible error handling with manual Display implementations
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Added feature flags and made std dependencies optional |
| src/lib.rs | Added no_std configuration and extern crate alloc |
| src/errors.rs | Added no_std-compatible error handling with manual Display implementations |
| src/traits.rs | Replaced rand imports with conditional std/no_std variants |
| src/schnorr_protocol.rs | Added conditional rand imports and alloc::vec::Vec |
| src/linear_relation/*.rs | Replaced std imports with alloc equivalents |
| src/group/*.rs | Added alloc::vec::Vec imports |
| src/duplex_sponge/*.rs | Added alloc::vec::Vec imports |
| src/composition.rs | Updated rand trait bounds for no_std compatibility |
| src/codec.rs | Added alloc::vec import |
| src/fiat_shamir.rs | Added conditional rand imports |
| .github/workflows/rust.yml | Added CI checks for no_std compilation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| } | ||
|
|
||
| for (scalar, base) in scalars.into_iter().zip(bases) { | ||
| for (scalar, base) in scalars.iter().zip(bases) { |
There was a problem hiding this comment.
This change from scalars.into_iter() to scalars.iter() changes the semantic behavior. The original code consumed the scalars iterator, but now it borrows it, which may cause issues if the function signature expects to take ownership of scalars.
No description provided.