Skip to content

Implement selections Beacon API endpoints to support DVT middleware #7016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 81 commits into
base: unstable
Choose a base branch
from

Conversation

chong-he
Copy link
Member

@chong-he chong-he commented Feb 20, 2025

Issue Addressed

Proposed Changes

  • Add beacon_committee_selections endpoint
  • Test beacon committee aggregator and confirmed working
  • Add sync_committee_selections endpoint
  • Test sync committee aggregator and confirmed working

Additional Info

Thank you @michaelsproul and @macladson for the help and guidance

@chong-he chong-he added work-in-progress PR is a work-in-progress skip-ci Don't run the `test-suite` dvt Distributed validator technology e.g. SSV, Obol and removed skip-ci Don't run the `test-suite` labels Feb 20, 2025
@chong-he chong-he mentioned this pull request Feb 27, 2025
@chong-he chong-he changed the title Add selections API endpoints to support DVT middleware Implement selections Beacon API endpoints to support DVT middleware Mar 13, 2025
@chong-he
Copy link
Member Author

chong-he commented Mar 20, 2025

With the commit 8b2f058 where VC sends partial signatures in parallel for all validators for a slot, I believe the aggregated attestations are successful (during testing) now, thank you @michaelsproul !

Lighthouse VC logs:

{"log":"Mar 20 06:36:24.046 INFO Successfully published attestation      type: aggregated, slot: 37, committee_index: 0, head_block: 0xdb186315afecb3d1134d03eb2d5b04b83a21ede56be6563e3bff304b103bf4b6, signatures: 24, aggregator: 58, service: attestation\n","stream":"stderr","time":"2025-03-20T06:36:24.04690072Z"}

for every slot now

Charon logs:

{"log":"06:36:24.074 INFO bcast      Successfully submitted attestation aggregations to beacon node {\"delay\": \"8.074945477s\", \"duty\": \"37/aggregator\", \"peer\": \"twinkling-pen\", \"protocol\": \"/charon/parsigex/2.0.0\"}\n","stream":"stderr","time":"2025-03-20T06:36:24.074999639Z"}

for every slot now too

@KaloyanTanev could you give it a try and confirm that the beacon committee selection endpoint is working as intended?

Thanks

@chong-he chong-he added ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Apr 23, 2025
Copy link
Member

@dknopik dknopik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've added a few notes.

@chong-he chong-he added work-in-progress PR is a work-in-progress and removed ready-for-review The code is ready for review labels May 6, 2025
Copy link

mergify bot commented May 7, 2025

This pull request has merge conflicts. Could you please resolve them @chong-he? 🙏

@chong-he chong-he added ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels May 9, 2025
@chong-he
Copy link
Member Author

chong-he commented May 9, 2025

Thanks! I've added a few notes.

Thank you so much for the review and help. All revised accordingly, let me know if further changes required.

Comment on lines +708 to +709
// Construct proof for prior slot.
let proof_slot = slot - 1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why this is needed (here and above)? It seems weird to me to compute the proof for the previous slot.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly don't know why. @michaelsproul might have an answer for this.

In the distributed mode, I follow the same logic to also compute slot - 1

macladson added a commit that referenced this pull request May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dvt Distributed validator technology e.g. SSV, Obol ready-for-review The code is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants