-
Notifications
You must be signed in to change notification settings - Fork 868
Implement selections
Beacon API endpoints to support DVT middleware
#7016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: unstable
Are you sure you want to change the base?
Conversation
selections
API endpoints to support DVT middlewareselections
Beacon API endpoints to support DVT middleware
With the commit 8b2f058 where VC sends partial signatures in parallel for all validators for a slot, I believe the aggregated attestations are successful (during testing) now, thank you @michaelsproul ! Lighthouse VC logs:
for every slot now Charon logs:
for every slot now too @KaloyanTanev could you give it a try and confirm that the beacon committee selection endpoint is working as intended? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I've added a few notes.
This pull request has merge conflicts. Could you please resolve them @chong-he? 🙏 |
Thank you so much for the review and help. All revised accordingly, let me know if further changes required. |
// Construct proof for prior slot. | ||
let proof_slot = slot - 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know why this is needed (here and above)? It seems weird to me to compute the proof for the previous slot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I honestly don't know why. @michaelsproul might have an answer for this.
In the distributed mode, I follow the same logic to also compute slot - 1
Issue Addressed
Proposed Changes
beacon_committee_selections
endpointsync_committee_selections
endpointAdditional Info
Thank you @michaelsproul and @macladson for the help and guidance