Add additional broadcast validation tests for Fulu/PeerDAS #7325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eserilev
added
das
michaelsproul
requested changes
Apr 22, 2025
Comment on lines
1617
to
1626
| let deneb_enabled_forks = ForkName::list_all() | ||
| .into_iter() | ||
| .filter(|f| f.deneb_enabled()) | ||
| .collect::<Vec<_>>(); | ||
|
|
||
| let futures = deneb_enabled_forks | ||
| .into_iter() | ||
| .map(blobs_or_columns_seen_on_gossip_without_block_and_no_http_blobs_or_columns); | ||
|
|
||
| join_all(futures).await; |
There was a problem hiding this comment.
I agree this pattern feels a bit repetitive.
We could do what we do in the other tests like beacon_chain, op_pool, network, which is use test_spec to initialise the ChainSpec from the FORK_NAME environment variable. This would require us to add some makefile & CI support for the HTTP tests, and exclude them from make test-release.
michaelsproul
added
waiting-on-author
eserilev
added
ready-for-review
|
Some required checks have failed. Could you please take a look @eserilev? 🙏 |
mergify
bot
added
waiting-on-author
|
Some required checks have failed. Could you please take a look @eserilev? 🙏 |
jimmygchen
reviewed
May 20, 2025
eserilev
added
ready-for-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Closes #6855
Proposed Changes
Add PeerDAS broadcast validation tests and fix a small bug where
sampling_columns_indicesis none (indicating that we've already sampled the necessary columns) andprocess_gossip_data_columnsgets calledAdditional Info
If theres a better way to format these tests (maybe have CI feed in a list of forks to the relevant tests?) I can do that instead