-
Notifications
You must be signed in to change notification settings - Fork 875
Add additional broadcast validation tests for Fulu/PeerDAS #7325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eserilev
wants to merge
11
commits into
sigp:unstable
Choose a base branch
from
eserilev:fulu-broadcast-validation-tests
base: unstable
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
102df5b
Add test coverage for fulu and a small bugfix
eserilev 093ab14
linting
eserilev e19333e
run http_api tests for fork variants
eserilev 999a1c0
add test to ci
eserilev 2bb0eae
all broadcast validation tests have test variants
eserilev 2c0370d
update makefile
eserilev cb9cdfa
update Makefile
eserilev d2f16a4
fix makefile
eserilev 6895fd7
Merge branch 'unstable' into fulu-broadcast-validation-tests
eserilev 54d177a
add test success check
eserilev d76586c
Merge branch 'unstable' into fulu-broadcast-validation-tests
eserilev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree this pattern feels a bit repetitive.
We could do what we do in the other tests like
beacon_chain
,op_pool
,network
, which is usetest_spec
to initialise theChainSpec
from theFORK_NAME
environment variable. This would require us to add some makefile & CI support for the HTTP tests, and exclude them frommake test-release
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep sounds good!