Skip to content

Update mergify to prevent incorrectly firing rule to update ready-for-review label #7525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 28, 2025

Conversation

jimmygchen
Copy link
Member

Unfortunately I think the mergify rules need to be updated again.

With the current rule, it's not possible to mark a PR with passing CI as waiting-on-author. Mergify will immediately remove this label and mark it as ready-for-review because of the following rule:

- name: Update labels when PR is unblocked
conditions:
- -closed
- -draft
- label=waiting-on-author
- -conflict
# Unfortunately, it doesn't look like there's an easy way to check for PRs pending
# CI workflows approvals.
- check-success=test-suite-success
- check-success=local-testnet-success
- "#review-requested > 0"

I've now added an additional condition, so it won't fire if there's a change request or unresolved thread:

      - or:
         - "#changes-requested-reviews-by = 0"
         - "#review-threads-unresolved = 0"

I'm hoping this improves things, tested the conditions against the following PRs:

If this condition proves to be painful without much benefit we can consider removing it, but I'm willing to give it another try.

I've also removed the comment section of this condition, i'm getting feedback that it adds unnecessary noise.

@jimmygchen jimmygchen requested review from jxs and michaelsproul May 27, 2025 13:19
@jimmygchen jimmygchen added ready-for-review The code is ready for review infra-ci skip-ci Don't run the `test-suite` labels May 27, 2025
Copy link

mergify bot commented May 27, 2025

Some required checks have failed. Could you please take a look @jimmygchen? 🙏

@mergify mergify bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels May 27, 2025
@jimmygchen jimmygchen changed the title Update mergify rules so that I can add waiting-on-author on a PR th… Update mergify to prevent incorrectly firing rule to update ready-for-review label May 27, 2025
@jimmygchen jimmygchen merged commit 999b045 into sigp:stable May 28, 2025
28 of 30 checks passed
@jimmygchen jimmygchen deleted the mergify-again branch May 28, 2025 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra-ci skip-ci Don't run the `test-suite` waiting-on-author The reviewer has suggested changes and awaits thier implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants