Update mergify to prevent incorrectly firing rule to update ready-for-review
label
#7525
+4
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately I think the mergify rules need to be updated again.
With the current rule, it's not possible to mark a PR with passing CI as
waiting-on-author
. Mergify will immediately remove this label and mark it asready-for-review
because of the following rule:lighthouse/.github/mergify.yml
Lines 41 to 51 in 7759cb8
I've now added an additional condition, so it won't fire if there's a change request or unresolved thread:
I'm hoping this improves things, tested the conditions against the following PRs:
ready-for-review
ready-for-review
If this condition proves to be painful without much benefit we can consider removing it, but I'm willing to give it another try.
I've also removed the
comment
section of this condition, i'm getting feedback that it adds unnecessary noise.